Enhance API-Testing-Guidelines.md #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlurien
requested review from
shilpa-padgaonkar,
rartych,
patrice-conil,
RubenBG7 and
PedroDiez
as code owners
PedroDiez
reviewed
May 16, 2024
rartych
reviewed
May 16, 2024
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Proposal updated with comments and feedback after dedicated session on May 16th. - Tests coverage section moved to to the top, merging legacy section "Test Cases contribution for APIs". - Added distinction between basic and enhanced test plan, to be aligned with Release Management proposal. There is no proper definition of what is basic or enhanced, so I suggested some initial test. - Added explicitly that environment variables may be kept in a separated file. We should enhance this part with more details and a suggested template.
|
In the latter commit: Proposal updated with comments and feedback after dedicated session on May 16th.
Please review these changes. |
mdomale
reviewed
May 24, 2024
rartych
reviewed
May 27, 2024
mdomale
reviewed
May 27, 2024
mdomale
reviewed
May 27, 2024
mdomale
reviewed
May 27, 2024
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
mdomale
reviewed
Jun 3, 2024
mdomale
reviewed
Jun 3, 2024
mdomale
reviewed
Jun 3, 2024
PedroDiez
reviewed
Jun 11, 2024
rartych
reviewed
Jun 11, 2024
rartych
reviewed
Jun 11, 2024
rartych
reviewed
Jun 11, 2024
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
Co-authored-by: Pedro Díez García <pedro.diezgarcia@telefonica.com>
PedroDiez
previously approved these changes
Jun 11, 2024
Updated with latest comments
…om/jlurien/Commonalities into doc/enhancement-testing-guidelines
|
I think I have incorporated all suggestions and feedback, please double check |
|
@jlurien Except above 1 comment PR looks fine to us . |
Fix feature filenames examples
|
Final comments addressed. Thanks for the feedback and corrections. |
|
@jlurien Thanks for accommodating comments .LGTM now cc @akoshunyadi @shilpa-padgaonkar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Enhances API testing guidelines with much more details and explanations. Initial version was too basic to assure consistent and coherent testing plans.
Which issue(s) this PR fixes:
Fixes #158
Special notes for reviewers:
This is a first draft following proposal and initial feedback in #158.
Changelog input