Update Simple Edge Discovery flows #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevsy
requested review from
gunjald,
crissancas,
FabrizioMoggio and
sergiofranciscoortiz
as code owners
crissancas
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Kevin, I would add an specific comment to emphazise that the interface used is the NBI.
Additionally, I think there is no need for a strict dependency on the hyperscaler account, I mean, our idea is also to use this API with GSMA Telco Edge solution. Could you explain why is needed a hyperscaler account?
Incorporated @crissancas comments (regarding hyperscaler and NBI)
|
@crissancas thanks, changes made and committed to this PR - please can you review? |
|
Thanks Kevin! |
|
Re-opened as it was closed without merge - @crissancas please can you merge to main? Thanks! |
crissancas
approved these changes
Jul 19, 2023
|
Sorry Kev! My mistake, I didn't realize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified the first scenario and added and additional scenario for Simple Edge Discovery