Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of the simple edge discovery API as per the CAMARA commonality group guidelines #122

Closed
wants to merge 2 commits into from

Conversation

gunjald
Copy link
Collaborator

@gunjald gunjald commented Aug 6, 2023

Contribution from 6G-XR (https://www.6g-xr.eu/) towards the alignment of the simple edge discovery API as per the CAMARA commonality group guidelines for the REST API

…very.yaml

Contribution from 6G-XR (https://www.6g-xr.eu) towards the alignment of the simple edge discovery API as per the CAMARA commonality group guidelines for the REST API
Alignment changes for CAMARA commonality guidelines simple_edge_disco…
@gunjald gunjald closed this Aug 6, 2023
@gunjald
Copy link
Collaborator Author

gunjald commented Aug 6, 2023

Accidentally raised the request hence closing.

@gunjald
Copy link
Collaborator Author

gunjald commented Aug 6, 2023

Contribution from 6G-XR (https://www.6g-xr.eu/) towards the alignment of the simple edge discovery API as per the CAMARA commonality group guidelin](#122)

@gunjald gunjald reopened this Aug 6, 2023
@gunjald gunjald marked this pull request as ready for review August 6, 2023 20:06
@Kevsy
Copy link
Collaborator

Kevsy commented Aug 8, 2023

Thanks @gunjald - in parallel I've been doing the same exercise, namely to align the data types and error types with those used in other CAMARA APIs (in particular the various device identifiers used in QOD and Device Status) and to ensure alignment with Commonalities API style guide. I also propose to simplify the API by removing the unused query parameters and datatypes (zone, region) which are rather part of the 'full' discovery API.

So: I propose I take the guidance from the commit here and look to combine it with my new version (the goal is the same).

@Kevsy
Copy link
Collaborator

Kevsy commented Aug 11, 2023

This should be fixed with #127 which aligns the API with Commonalities

@Kevsy
Copy link
Collaborator

Kevsy commented Oct 9, 2023

Hi @gunjald , the relevant changes are incorporated into PR #127, with the exception of 3-legged authorisation as we need to discuss whether Simple Edge Discovery should require end user consent, even if it is only the network IP range being used to determine the closest MEC platform. Overall this is part of a bigger discussion that encompasses all CAMARA APIs - so my proposal is to close this PR (since PR 127 incorporates most of the changes) and then we ask for the Steering Commitee position on exceptions to 3-legged auth.

@Kevsy Kevsy closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants