Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patch (OAS version +documentation correction) #146

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented Sep 20, 2023

Fixes #144 and #145

Copy link
Collaborator

@gunjald gunjald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if the Port is optional and the MSISDN is not mandatory then does it mean the API is not specific to a subscriber but the result could be also valid for other devices who may be assigned the same public IP but different port?

@Kevsy
Copy link
Collaborator Author

Kevsy commented Oct 2, 2023

So if the Port is optional and the MSISDN is not mandatory then does it mean the API is not specific to a subscriber but the result could be also valid for other devices who may be assigned the same public IP but different port?

Correct, because the goal is not to identify the subscriber: it's to identify the closest MEC to the terminal. The public IP address subnet indicates which of the network Packet Gateways issued it, and since the operator knows which packet gateway is nearest to each MEC, that is sufficient to answer the API call.

Copy link
Collaborator Author

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added fix to issue #148

@crissancas crissancas merged commit bfc7b0c into main Nov 14, 2023
@Kevsy Kevsy deleted the Kevsy-patch-12 branch February 6, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Edge Discovery OAS version should be 3.0.3
3 participants