Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository cleanup #235

Merged
merged 7 commits into from
May 13, 2024
Merged

Repository cleanup #235

merged 7 commits into from
May 13, 2024

Conversation

Kevsy
Copy link
Collaborator

@Kevsy Kevsy commented May 1, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Agreed on call 30th April 2024 - repository is difficult to navigate and contains many legacy/inactive documents. It is also not closely following the CAMARA repository structure

Which issue(s) this PR fixes:

Fixes #234

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

github-actions bot commented May 1, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ JSON eslint-plugin-jsonc 1 0 0 1.5s
✅ JSON jsonlint 1 0 0.2s
✅ JSON prettier 1 1 0 0.93s
✅ JSON v8r 1 0 2.34s
❌ OPENAPI spectral 2 2 4.55s
✅ REPOSITORY git_diff yes no 0.55s
✅ REPOSITORY secretlint yes no 4.57s
❌ YAML yamllint 2 1 0.59s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@Kevsy
Copy link
Collaborator Author

Kevsy commented May 1, 2024

Tip for reviewers: clone the Kevsy-patch-10 branch to your local machine so you can browse the directory structure visually (Finder/Explorer)

Kevsy added 2 commits May 2, 2024 09:55
Now uses template proposed in Governance issue 124
Now meets Governance issue 124
Copy link
Collaborator

@javierlozallu javierlozallu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevsy, as we now have a ‘child’ repository, would it be appropriate to include the link to refer to the fact that the SED API is now in that new repository?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Kevsy
Copy link
Collaborator Author

Kevsy commented May 9, 2024

@Kevsy, as we now have a ‘child’ repository, would it be appropriate to include the link to refer to the fact that the SED API is now in that new repository?

Thanks @javierlozallu good idea, and done: I have removed the SED YAML from the Edge Cloud repo and instead left a link to the SED repo.

I have also made the fixes from your review (and @nicolacdnll 's review - thanks both)

@Kevsy Kevsy merged commit 0ca2ed5 into main May 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository cleanup
3 participants