Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TI API Rel 0.9.6: sourceTrafficFilters #278

Merged
merged 16 commits into from
Sep 4, 2024
Merged

TI API Rel 0.9.6: sourceTrafficFilters #278

merged 16 commits into from
Sep 4, 2024

Conversation

FabrizioMoggio
Copy link
Collaborator

@FabrizioMoggio FabrizioMoggio commented Jun 26, 2024 •
edited
Loading

@FabrizioMoggio
TI API Rel 0.9.6: sourceTrafficFilters
ff07922 
- removed rel number in "version" field according to:camaraproject#272
- sourceTrafficFilters added according to: camaraproject#230 (comment)
- updated link to Identity and Consent: CAMARA-Security-Interoperability: camaraproject#277
@FabrizioMoggio FabrizioMoggio added documentation Indicating issues with API documentation or supplementary documents API improvement Traffic Influence API correction Suggesting corrections of API specification or indicating misalignment with API design guidelines labels Jun 26, 2024
@FabrizioMoggio
Copy link
Collaborator Author

to be aligned with: #247

@FabrizioMoggio
Copy link
Collaborator Author

FabrizioMoggio commented Jul 1, 2024 •
edited
Loading

@gunjald I'm so sorry you did a great effort to go through the documentation. unfortunately that was the old version, I actually uploaded the new TI API in the wrong folder. Anyway it was mostly the same file , just one line was different. so no problem

@FabrizioMoggio
Delete code/Test_definitions/Traffic_Influence.yaml
cf80523 
file uploaded in the wrong folder
@gunjald
Copy link
Collaborator

gunjald commented Jul 1, 2024

@gunjald I'm so sorry you did a great effort to go through the documentation. unfortunately that was the old version, I actually uploaded the new TI API in the wrong folder. Anyway it was mostly the same file , just one line was different. so no problem

No worries :-) I hope we have better APIs and documents to help the adoptions.

This was referenced Jul 3, 2024
Open
Open
@FabrizioMoggio
Update Device with Commonalities
ead7ba4 
Alignment with Device according to: camaraproject#247
@FabrizioMoggio
MegaLinter Fix
3d7c18c
@FabrizioMoggio
MegaLinter Fix
f6fe4e1 
it is unfortunate that Common YAML is not compatible with our linter :-(
@FabrizioMoggio
MegaLinter Fix
ac09c0f
@FabrizioMoggio
MegaLinter Fix
6b0d3ec
@FabrizioMoggio
Alignment with Device and EdgeAppMng API
607c452 
- Alignment with Device according to: camaraproject#247
- Alignment with "Edge Application Management API" according to: camaraproject#278 (comment) and camaraproject#278 (comment)
@FabrizioMoggio
MegaLinter Fix
479a95b
@FabrizioMoggio
Copy link
Collaborator Author

I also aligned the name of the parameters for Zones and Regions in the code.

  • EdgeCloudRegion
  • EdgeCloudZoneId

@FabrizioMoggio
Copy link
Collaborator Author

@gunjald is there still pending on this PR? or can it be approved?

@FabrizioMoggio
documentation
ae198c5 
improved according the the comments from Deepak
@FabrizioMoggio
MegaLinter Fix
295d26e
@FabrizioMoggio
Copy link
Collaborator Author

@gunjald now all your comments should be addressed :-). Thank you very much for your support.

@FabrizioMoggio
Copy link
Collaborator Author

Can we approve the PR?

@nicolacdnll nicolacdnll merged commit b1d18ac into camaraproject:main Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunjald gunjald gunjald left review comments

@nicolacdnll nicolacdnll nicolacdnll approved these changes

@Kevsy Kevsy Awaiting requested review from Kevsy Kevsy is a code owner

@crissancas crissancas Awaiting requested review from crissancas crissancas is a code owner

@gainsley gainsley Awaiting requested review from gainsley gainsley is a code owner

@javierlozallu javierlozallu Awaiting requested review from javierlozallu

Assignees
No one assigned
Labels
API improvement correction Suggesting corrections of API specification or indicating misalignment with API design guidelines documentation Indicating issues with API documentation or supplementary documents Traffic Influence API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabrizioMoggio @gunjald @nicolacdnll