-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Test Definition and patch release r1.3 #148
Conversation
Fixed code: @NumberVerification_phone_number_share201_missing_scope Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED ) @NumberVerification_phone_number_share202_expired_access_token Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Fixed code for 2 scenarios: @NumberVerification_verify201_missing_scope Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED ) @NumberVerification_verify202_expired_access_token Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Change r1.2t to r1.3 Fixed link to the wiki
Changed in title to r1.3
Introduce r1.3 with Test Definition fixing.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Add PR reference
@bigludo7 looks good to me. Regarding the CHANGELOG my understanding is that in case of patch release only the changes towards the last public release need to be listed (which is r1.2). At least that is the practice within e.g. https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md and also in line with our CHANGELOG template:
@tanjadegroot any further thoughts on that? |
code/Test_Definitions/number-verification-device-phone-number-share.feature
Outdated
Show resolved
Hide resolved
code/Test_Definitions/number-verification-device-phone-number-share.feature
Outdated
Show resolved
Hide resolved
…share.feature Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>
Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>
Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>
…share.feature Co-authored-by: Fernando Prado Cabrillo <fernando.pradocabrillo@telefonica.com>
Thanks @fernandopradocabrillo for the review !!! |
If we are not going to dismiss the r1.2 then I think @hdamker is right and in the changelog we should only include what is new in the r1.2 |
Remove from the changelog in the r1.3 the information from the r1.2
@fernandopradocabrillo @hdamker Updated the changelog to follow your recommendation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@camaraproject/release-management_maintainers @AxelNennker Kind reminder as this one should be quickly merged. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from release management perspective. Minor suggestions on the CHANGELOG.md you can decide to take or not.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Remove main change part
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR fixes following Test Case definition to be aligned with the yaml & other API:
@NumberVerification_phone_number_share201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_phone_number_share202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
@NumberVerification_verify201_missing_scope
Changed code to PERMISSION_DENIED (previous was UNAUTHENTICATED )
@NumberVerification_verify202_expired_access_token
Changed code to UNAUTHENTICATED (previous was AUTHENTICATION_REQUIRED )
Which issue(s) this PR fixes:
Fixes #147
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.