Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of IpFlowDescription to allow asymmetric QoS flows and (re)introduce protocol definitions #51

Closed
hdamker opened this issue Oct 5, 2022 · 2 comments
Labels
enhancement New feature or request QoD QoD-backlog

Comments

@hdamker
Copy link
Collaborator

hdamker commented Oct 5, 2022

@emil-cheung proposed in PR #37 to introduce more detailed flow descriptions with an array of flowdescriptions of IpFlowDescriptions objects. It addresses the protocolIn/protocolOut parameter design issue (#32) and would allow asymmetric QoS flows (#36). Going forward it will also allow multiple flow descriptions as discussed in #13.

The PR wasn't merged as the proposed updated version of the simple QoD API (v0.8.0) #43 has solved issue #32 by omitting the parameters protocolIn and protocolOut, combined the previous two QoD APIs in one, and introduced other changes which require to rebase the proposed changes.

This issue is to preserve the proposal. Proposed YAML:
qos-stable-latency.yaml.txt

flowDescriptions within CreateSession schema:

flowDescriptions:
    type: array
    items:
      $ref: '#/components/schemas/IpFlowDescription'
    minItems: 1
    maxItems: 2
IpFlowDescription:
      type: object
      required:
        - direction
        - protocol
        - ueAddr
        - uePorts
        - remoteAddr
        - remotePorts        
      properties:
        direction:
          $ref: '#/components/schemas/Direction'
        protocol:
          $ref: '#/components/schemas/Protocol'
        ueAddr:
          $ref: '#/components/schemas/Ipv4Addr'
        uePorts:
          $ref: '#/components/schemas/PortsSpec'
        remoteAddr:
          $ref: '#/components/schemas/Ipv4Addr'
        remotePorts: 
          $ref: '#/components/schemas/PortsSpec'
@hdamker
Copy link
Collaborator Author

hdamker commented Oct 5, 2022

As discussed in https://github.com/camaraproject/QualityOnDemand/blob/main/documentation/MeetingMinutes/MOM-2022-09-23.md the proposed way forward is to first implement the "simple" API as proposed with v0.8.0 in #43 and then add flowdescriptions later. Added label "backlog".

@hdamker
Copy link
Collaborator Author

hdamker commented Dec 14, 2023

MOM-2023-12-01:

@hdamker hdamker closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QoD QoD-backlog
Projects
None yet
Development

No branches or pull requests

1 participant