Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of broken links in README #150

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Correction of broken links in README #150

merged 1 commit into from
Sep 12, 2024

Conversation

hdamker
Copy link
Collaborator

@hdamker hdamker commented Sep 12, 2024

What type of PR is this?

Add one of the following kinds:

Correction

What this PR does / why we need it:

The links to the SimSwap YAML where still to sim_swap.yaml and there broken.

Which issue(s) this PR fixes:

Fixes # na

Special notes for reviewers:

Please note that the links within https://github.com/camaraproject/SimSwap/tree/r1.2/README.md would be still broken after the merge of this PR. Therefore I recommend to move the release tag r1.2 to towards the merge commit of this correction PR (can be done without harm as none of the release assets were touched).

@hdamker hdamker added bug Something isn't working subproject management Indicating issues with subproject repository or release management process labels Sep 12, 2024
@hdamker
Copy link
Collaborator Author

hdamker commented Sep 12, 2024

@bigludo7 @fernandopradocabrillo would be great if you could take care of this PR asap.

cc: @tanjadegroot

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 3.27s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.82s
✅ YAML yamllint 2 0 0.57s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this one

@hdamker hdamker merged commit 4409cfe into main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants