Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Test_definitions folder under code #1

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Sep 7, 2023

Reference issue #59 in Commonalities

Note: this commit suggests

/code/Test_definitions

...however for sub-projects with multiple APIs then the structure may be:

/code/API_defintions/{api_sub_group}/Test_definitions

e..g. /code/API_definitions/Discovery/Test_definitions

FabrizioMoggio added a commit to FabrizioMoggio/EdgeCloud that referenced this pull request Sep 13, 2023
Even if the folder structure for Test is not agreed yet:

camaraproject#138
camaraproject/Template_API_Repository#1
camaraproject/Commonalities#59

we can anyway discuss about the .feature file for the TI API.
@FabrizioMoggio
Copy link

FabrizioMoggio commented Sep 13, 2023

@Kevsy considering your proposal for the sub-projects with multiple APIs, then for sub-projects with just one APIs the structure should be:

/code/API_defintions/Test_definitions

.....also considering the API_definitions folder.

Or (option 2) the other way around, for sub-projects with multiple APIs then the structure should be:

/code/Test_defintions/{api_sub_group}/.feature

or

/code/Test_defintions/{api_sub_group}/cucumber

I would suggest this second option because if a Developer is used to work in a single API project, he/her expects to find the test folder under /code.

@MarkusKuemmerle
Copy link
Contributor

Code only should be in the provider implementation repos, not in the lead repos. The question is if tests are implementation specific or should be implementation independent. I would vote for the last one, then it makes sense to have it as /Test_definitions/ only in the lead repos.

@Kevsy
Copy link
Contributor Author

Kevsy commented Sep 27, 2023

Code only should be in the provider implementation repos, not in the lead repos.

Correct, although to avoid confusion in this thread, Template Lead repository sets the structure code/API_definitions (i.e. /code/is part of the path)- so I think it's fair to have the paths suggested by @FabrizioMoggio above (which include /code/)

The question is if tests are implementation specific or should be implementation independent. I would vote for the last one, then it makes sense to have it as /Test_definitions/ only in the lead repos.

Yes, I agree

@Kevsy
Copy link
Contributor Author

Kevsy commented Oct 3, 2023

HI @MarkusKuemmerle - I cannot see a CODEOWNER or Maintainers for Template Lead Repository, which means the PR Cannot be merged. Please can you advise?

@MarkusKuemmerle
Copy link
Contributor

In a template we can't have maintainers or code owners, because these would be automatially copied then in the Sub Project repos created with the template. The admins can do the merge / changes.

You only want to add one additional folder for testing, correct? Shall we add this folder to all exisiting Lead Repos too to be consistent with the template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants