Update setup_script to fetch landing page #101
Conversation
setup_script.sh
Outdated
| ### | ||
| echo "Checking for required files" | ||
|
|
||
| if [[ ! -d ../Distro/db ]] |
There was a problem hiding this comment.
For this, it should be sufficient to check that whichever mongo uri is being used is accessible. Distro/db is just a hacky way to ensure persistence/fs backups of the mongo data.
There was a problem hiding this comment.
I have removed the lines as there is a check for mongo uri in the setup script and committed the changes: 05bd6cc
…into backup-dev updated setup script
|
Since backup-dev is currently holding @YashKumarVerma 's work, I'd appreciate their input here too. |
|
Sure, I'll go through this |
|
Thanks for your time! |
service/database/connector.js
Outdated
| // connector.init().catch((e) => { | ||
| // console.error("error connecting to database"); | ||
| // process.exit(1); | ||
| // }); |
There was a problem hiding this comment.
I do not think these lines are needed anymore as this is being done in caracal.js
There was a problem hiding this comment.
Yes, you are right! They have been commented out.
|
A pull request (#98) was submitted resolving the issue (#96) before this pull request was sent. I'm a bit confused on this part:
Thanks ! |
|
Ah, this must be a peril of messing with commit history. None of the commits in this PR changed matching #98, but the changes are part of this anyway. I think it's resolved. I'll do a fair bit more testing before merging backup-dev in, but I think this is good to go. Any objections? |
|
None from my side! |
|
Thanks!! |
Summary
The setup_script was updated to include all the required files to run the application smoothly using node.
Motivation
Testing
It has been tested manually on my local system