Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug from issue #757 , added showdown library and converted markdown to html in workbench.js #759

Closed
wants to merge 2 commits into from

Conversation

hannyP
Copy link

@hannyP hannyP commented Mar 13, 2024

fixed the bug

I am an outreachy 2024 applicant and found this issue while running the project on my local machine

Testing

it hasn't been tested as only UI elements were being tested in the repo.

Questions

I used the showdown library to solve this issue , let me know if i shouldn't have used any library do tackle this issue

@hannyP hannyP changed the title Fixed bug from #757 , added showdown library and converted markdown to html in workbench.js Fixed bug from issue #757 , added showdown library and converted markdown to html in workbench.js Mar 13, 2024
@hannyP
Copy link
Author

hannyP commented Mar 13, 2024

now when you click on help in workbench tab it should display the user guide like this
Screenshot 2024-03-13 164941

Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change and I think It'll look good!

@@ -0,0 +1,3 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include setting/config files for editors in PRs.

Comment on lines +1 to +3
{
"liveServer.settings.port": 5501
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"liveServer.settings.port": 5501
}

@birm birm mentioned this pull request Apr 24, 2024
@birm
Copy link
Member

birm commented Apr 24, 2024

turns out to be fixed with #683

@birm birm closed this Apr 24, 2024
@hannyP hannyP deleted the develop branch June 14, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants