Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make] Support windows in makefile #1

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

tobil4sk
Copy link

On windows, the makefile fails because pwd returns a unix style path. This changes the makefile to use windows paths if windows is detected. This allows a successful build on windows.

@chetmurthy
Copy link
Contributor

I deleted my previous comment: your Windows changes worked (I made a clerical error).

I made a mistake when I created this repo, somehow the default branch got set to "main" even though I always use "master". I changed that just now, just thought I should let you know.

@chetmurthy
Copy link
Contributor

FYI, I changed "main" to "main-DO-NOT-USE" so it would be obvious.

@chetmurthy
Copy link
Contributor

Ugh, the opam-ci windows build is .... pretty opaque, and it seems like in fact the windows build failed after all. I think it's b/c revdeps failed (b/c most of the pa_ppx_* packages are not gonna work on windows). Sigh. Let's see where things shake out in the morning. In any case, I'll try to push thru your camlp5-on-Windows fixes: maybe over time I can fixup enough of the pa_ppx packages that the Windows CI builds start working.

@tobil4sk tobil4sk deleted the feature/windows-support branch December 14, 2024 09:37
@tobil4sk
Copy link
Author

Many thanks! Let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants