Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the validation into a pre-commit hook #1083

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Move the validation into a pre-commit hook #1083

merged 1 commit into from
Apr 13, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Apr 12, 2023 •
edited
Loading

Also fix pr-check that validates the config with a wrong version of the schema

@sbrunner sbrunner force-pushed the validate-pre-commit branch 2 times, most recently from b5e2653 to 8900cb2 Compare April 12, 2023 14:41
@sbrunner sbrunner force-pushed the validate-pre-commit branch from 8900cb2 to f74a13d Compare April 12, 2023 14:45
@sbrunner sbrunner marked this pull request as ready for review April 12, 2023 14:57
@sbrunner sbrunner requested a review from arnaud-morvan April 12, 2023 14:57
arnaud-morvan
arnaud-morvan approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust you

@sbrunner sbrunner merged commit b4e6436 into master Apr 13, 2023
@sbrunner sbrunner deleted the validate-pre-commit branch April 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan