Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandit, remove pyroma #278

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add bandit, remove pyroma #278

merged 2 commits into from
Oct 4, 2021

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner force-pushed the bandit branch 4 times, most recently from 269ed05 to e5b7a5b Compare September 22, 2021 08:19
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments on descriptions.

@@ -192,6 +192,15 @@ def get_config() -> c2cciutils.configuration.Configuration:
"print_environment_variables": True,
"print_github_event": True,
"black_config": {"propertires": {"line-length": 110}},
"prospector_config": {
"propertires": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"propertires": {
"properties": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups :-)

@@ -146,6 +146,24 @@
{ "const": false }
]
},
"checks_prospector_config": {
"title": "Checks Prospector configuration",
"description": "The Black configuration check configuration",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "The Black configuration check configuration",
"description": "The Prospector check configuration",

@@ -276,7 +294,7 @@
},
"checks_print_config": {
"title": "Checks print config",
"description": "The print the autogenerated configguration",
"description": "The print the auto-generated configuration",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand, do you want to say: "Print the auto-generated configuration"

@sbrunner sbrunner merged commit 170cf38 into master Oct 4, 2021
@sbrunner sbrunner deleted the bandit branch October 4, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants