Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra 'With error' message #84

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Remove extra 'With error' message #84

merged 1 commit into from
Feb 8, 2021

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Feb 5, 2021

After a failing audit

@sbrunner
Remove extra 'With error' message
75e87ca 
After a failing audit
arnaud-morvan
arnaud-morvan reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global_success is always true, so this might not have any effect or I miss something.

@sbrunner
Copy link
Member Author

sbrunner commented Feb 8, 2021

E.-g. at line 202 success can be set to False
At line 207 global_success = global_success and success wuth Sucess = False => global_success = False...
Did I miss somthing?

@arnaud-morvan
Copy link
Member

Yes, you're right, global_success = global_success and success is in the for loop and you need success of the current loop status for the logs.
Everything looks good to me now.

@sbrunner sbrunner merged commit 241af52 into master Feb 8, 2021
@sbrunner sbrunner deleted the rm-extra-message branch February 8, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

@danduk82 danduk82 Awaiting requested review from danduk82

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan