Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the checks (deprecated by pre-commits) #964

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Remove the checks (deprecated by pre-commits) #964

merged 1 commit into from
Apr 6, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jan 12, 2023 •
edited
Loading

Replace it by a command that just print the environment information

@sbrunner sbrunner added the chore Build, CI, Code style, Types, Test, ... label Jan 12, 2023
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch 4 times, most recently from c6a71d8 to 894cb76 Compare January 12, 2023 13:54
@sbrunner sbrunner added enhancement New feature and removed chore Build, CI, Code style, Types, Test, ... labels Jan 12, 2023
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch 14 times, most recently from 943afbe to 9d907f1 Compare January 12, 2023 15:55
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch 6 times, most recently from 114bc32 to 85528b6 Compare January 14, 2023 10:56
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch 2 times, most recently from 9830fd7 to bb568f9 Compare April 5, 2023 11:57
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch 7 times, most recently from 9af3636 to 63c5c76 Compare April 5, 2023 14:14
@sbrunner sbrunner changed the title Add pre commits hooks Remove the checks (deprecated by pre-commits) Apr 5, 2023
arnaud-morvan
arnaud-morvan approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbrunner sbrunner force-pushed the add-pre-commit-hook branch from 63c5c76 to 026a3f6 Compare April 6, 2023 08:27
@sbrunner
Remove the checks (deprecated by pre-commits)
0a7cfd7 
Replace it by a commend that just print the environment information
@sbrunner sbrunner force-pushed the add-pre-commit-hook branch from 026a3f6 to 0a7cfd7 Compare April 6, 2023 08:38
@sbrunner sbrunner merged commit 0b98d5d into master Apr 6, 2023
@sbrunner sbrunner deleted the add-pre-commit-hook branch April 6, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-morvan arnaud-morvan arnaud-morvan approved these changes

Assignees
No one assigned
Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @arnaud-morvan