Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport master] Display all the messages #999

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[Backport master] Display all the messages #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions c2cciutils/lib/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,17 @@ def check_versions(
if not result:
return False

success = True
for package, version in versions_image.items():
if package not in versions_config:
print(f"Package {package} is not in the config file for the image {image}")
return False
success = False

if Version.from_string(versions_config[package]) > version:
print(
f"Package {package} is older than the config file for the image {image}: "
f"{versions_config[package]} > {version}."
)
return False
success = False

return True
return success