Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official Prometheus client, deprecate old one and StatsD #1852

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Use official Prometheus client, deprecate old one and StatsD #1852

merged 1 commit into from
Jun 8, 2023

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented May 26, 2023 •
edited
Loading

  • Using the standard lib
  • Opening a separate port
  • Work with the stats_db with push gateway or not
  • Include booth metric (from StatsD and old Prometheus)
  • Include standard Prometheus metrics
  • Support multiprocess
  • Support custom collectors by using Redis to collect all of them

@sbrunner sbrunner force-pushed the stats-full-prometheus-client branch 7 times, most recently from c384aee to 71ec4d2 Compare June 1, 2023 15:55
@sbrunner sbrunner force-pushed the stats-full-prometheus-client branch from 30b98e8 to 3176613 Compare June 2, 2023 16:18
@sbrunner sbrunner requested a review from gberaudo June 2, 2023 18:16
@sbrunner sbrunner marked this pull request as ready for review June 2, 2023 18:17
@sbrunner sbrunner changed the title Stats full prometheus client Use official Prometheus client, deprecate old one and StatsD Jun 3, 2023
@sbrunner sbrunner force-pushed the stats-full-prometheus-client branch 2 times, most recently from e97607b to ef844ee Compare June 3, 2023 07:54
gberaudo
gberaudo reviewed Jun 6, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
Makefile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
c2cwsgiutils/health_check.py Outdated Show resolved Hide resolved
c2cwsgiutils/prometheus_client.py Outdated Show resolved Hide resolved
c2cwsgiutils/prometheus_client.py Outdated Show resolved Hide resolved
c2cwsgiutils/redis_stats.py Outdated Show resolved Hide resolved
c2cwsgiutils/scripts/stats_db.py Outdated Show resolved Hide resolved
@sbrunner
Copy link
Member Author

sbrunner commented Jun 7, 2023

Thanks for your comments @gberaudo I do a first quick pass, I will do the rest later :-)

@sbrunner sbrunner force-pushed the stats-full-prometheus-client branch 2 times, most recently from 652fb49 to 2abc06d Compare June 7, 2023 15:56
@sbrunner
Use official Prometheus client, deprecate old one and StatsD
ed4c37a 
Includes:

 - Using the standard lib
 - Opening a separate port
 - Work with the stats_db with push gateway or not
 - Include booth metric (from StatsD and old Prometheus)
 - Include standard Prometheus metrics
 - Support multiprocess
 - Support custom collectors by using Redis to collect all of them
@sbrunner sbrunner force-pushed the stats-full-prometheus-client branch from 2abc06d to ed4c37a Compare June 7, 2023 16:55
@sbrunner
Copy link
Member Author

sbrunner commented Jun 8, 2023

Thanks @gberaudo

@sbrunner sbrunner merged commit e656c54 into master Jun 8, 2023
@sbrunner sbrunner deleted the stats-full-prometheus-client branch June 8, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @gberaudo