Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: 'NoneType' object is not iterable #2103

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix TypeError: 'NoneType' object is not iterable #2103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f118124
Fix TypeError: 'NoneType' object is not iterable
sbrunner Jan 10, 2024
59e14fc
Remove too many stack trace
sbrunner Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions c2cwsgiutils/prometheus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ def _deserialize_collected_data(
results: list[list[SerializedMetric]],
) -> Generator[prometheus_client.core.Metric, None, None]:
for serialized_collection in results:
if serialized_collection is None:
continue

for serialized_metric in serialized_collection:
if serialized_metric is None:
continue
Expand Down
2 changes: 1 addition & 1 deletion c2cwsgiutils/redis_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def run(self) -> None:
last_was_ok = True
except redis.exceptions.RedisError:
if last_was_ok:
LOG.warning("Redis connection problem", exc_info=True)
LOG.warning("Redis connection problem")
last_was_ok = False
time.sleep(0.5)
except Exception: # pylint: disable=broad-except
Expand Down
Loading