feat: diff k8s manifests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modridi
changed the title
modridi
force-pushed
the
k8s-manifest-diff
branch
from
7aa89c6
to
39260c9
Compare
ckaenzig
approved these changes
Jun 8, 2023
|
Just a small comment, more on the organization side of things: shouldn't we create a ticket to list all the modules of the stack where this still needs to be done? I don't like the idea that after this is merged we forget about this change and then the users will be confused as why the output of one module is different than the others. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR allows to diff rendered k8s manifests in Terraform plan upon Helm values change. "Raw" Helm values shown in the plan as ArgoCD application input are also kept for the moment.
Breaking change
Tests executed on which distribution(s)