Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Commit

Permalink
Fix unit tests on ruby 1.8.7
Browse files Browse the repository at this point in the history
  • Loading branch information
@mcanevet
mcanevet committed Mar 6, 2015
1 parent 034eb5c commit c8527e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/defines/archive_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
end

context 'without parameters' do
it { expect { is_expected.to compile.with_all_deps }.to raise_error(/Must pass url/) }
it { expect { is_expected.to compile.with_all_deps }.to raise_error(/Must pass/) }
end

context 'with url, without target' do
Expand Down

3 comments on commit c8527e4

@v6
Copy link

@v6 v6 commented on c8527e4 Feb 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// , Does this module still support the ancient Ruby 1.8.7?

That is, could I use it with a Puppet Master running CEntOS 6, as outlined in the following issue:

voxpupuli/puppet-consul#317 (comment)

@mcanevet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our modules does not support Ruy 1.8.7, it may or may not work, but we'll gladly merge PR that fixes issues on Ruby 1.8.7 as long as it does not complicate the code too much.

@v6
Copy link

@v6 v6 commented on c8527e4 Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're right, mcavenet:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not autoload puppet/type/archive: /etc/puppet/modules/archive/lib/puppet/type/archive.rb:53: syntax error, unexpected ':', expecting ')'
  newparam(:path, namevar: true) do
                          ^
/etc/puppet/modules/archive/lib/puppet/type/archive.rb:232: syntax error, unexpected ':', expecting ')'
...aram(:allow_insecure, boolean: true, parent: Puppet::Paramet...
                              ^
/etc/puppet/modules/archive/lib/puppet/type/archive.rb:232: Can't assign to true
...allow_insecure, boolean: true, parent: Puppet::Parameter::Bo...
                              ^
/etc/puppet/modules/archive/lib/puppet/type/archive.rb:232: syntax error, unexpected ':', expecting '='
...secure, boolean: true, parent: Puppet::Parameter::Boolean) d...
                              ^
/etc/puppet/modules/archive/lib/puppet/type/archive.rb:232: syntax error, unexpected ')', expecting $end
...t: Puppet::Parameter::Boolean) do
                              ^ on node myserver.ourdomain.tld
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Oh well, it was worth a try.

It seems that there is not an archive module that works for Puppet 3.

Please sign in to comment.