Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
max_len
value to thedriver::Options
struct. This option will limit the amount of bytes generated by the particular driver. As seen in practice, some generators could run forever with unbounded inputs so this tries to avoid that by setting the default value to 4096. Individual tests can override it if larger inputs are desired:I've also lowered the max_depth from 32 to 5. This should also prevent unbounded input generation and can be raised by the harness:
Finally, I've simplified the
driver::Rng::gen_from_bytes
implementation to avoid branching onDriverMode
. This ends up being a lot easier to reason about, since the driver no longer loops to try and provide incrementally larger inputs.