Refactor id of selector element to avoid AdBlock filter #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id "showAd" of the sms ad drop-down selector was being caught by AdBlock's filter lists. Simply refactoring the id to something else lets it get through without being blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://camsys.atlassian.net/browse/OBANYC-3141
This drop-down selector element in admin sms ad settings was missing sometimes. The id "showAd" of the selector was being caught by AdBlock's filter lists, causing the element to be blocked. Simply refactoring the id to something else avoids it getting flagged so it won't be blocked.