feat: Show info if no rule matched

camunda-community-hub · Apr 3, 2023 · cc2a12e · cc2a12e
1 parent ed7cffa
commit cc2a12e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/src/main/resources/public/css/app.css b/src/main/resources/public/css/app.css
@@ -131,6 +131,11 @@
   background: rgba(0, 125, 255, 0.2);
 }
 
+#decision-evaluation-message .alert-info {
+  background: #d4e5ff;
+  border-color: #7fb4bf;
+}
+
 .breadcrumb {
   font-size: 13px;
   margin-bottom: 8px;

diff --git a/src/main/resources/public/js/view-decision-evaluation.js b/src/main/resources/public/js/view-decision-evaluation.js
@@ -44,7 +44,7 @@ function loadDecisionEvaluationView() {
     }
 
     if (decisionEvaluation.evaluationFailureMessage) {
-      $("#decision-evaluation-failure-message").html(`
+      $("#decision-evaluation-message").html(`
         <div class="alert alert-danger" role="alert">
           ${decisionEvaluation.evaluationFailureMessage}
         </div>`);
@@ -74,6 +74,9 @@ function onDecisionEvaluationViewChanged(event) {
   $(".dmn-row-highlighted").each(function () {
     $(this).removeClass("dmn-row-highlighted");
   });
+  if (!decisionEvaluation.failedDecision) {
+    $("#decision-evaluation-message").html("");
+  }
 
   // update the diagram based on the active view
   let id = event.activeView.id;
@@ -107,6 +110,16 @@ function onDecisionEvaluationViewChanged(event) {
       let ruleIndex = rule.ruleIndex - 1;
       $(".tjs-table tbody tr")[ruleIndex].classList.add("dmn-row-highlighted");
     });
+
+    if (
+      currentEvaluatedDecision.matchedRules?.length === 0 &&
+      !decisionEvaluation.failedDecision
+    ) {
+      $("#decision-evaluation-message").html(`
+        <div class="alert alert-info" role="alert">
+          No rule of the decision table matched the given input.
+        </div>`);
+    }
   }
 
   if (event.activeView.type === "decisionTable") {

diff --git a/src/main/resources/templates/views/monitoring/decision-evaluations/decision-evaluation.html b/src/main/resources/templates/views/monitoring/decision-evaluations/decision-evaluation.html
@@ -94,14 +94,14 @@
               </button>
               <div class="detail-info hidden">
                 <div class="detail-entry">
-                  <b>Output</b>
+                  <b>Decision Output</b>
                   <span id="decision-output"></span>
                 </div>
               </div>
             </div>
           </div>
           <div class="decision-canvas-container">
-            <div id="decision-evaluation-failure-message"></div>
+            <div id="decision-evaluation-message"></div>
             <div id="canvas"></div>
           </div>
         </div>