Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mitigate adblocker issues #171

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix: mitigate adblocker issues #171

merged 1 commit into from
Apr 4, 2023

Conversation

SebastianStamm
Copy link
Collaborator

Description

  • Renamed tracking.js to mp_integration.js (short for mixpanel integration). Adblockers tend to block files called "tracking" or "mixpanel" purely based on filename
  • used optional chaining to not fail if the global tracking function is not defined, e.g. if an adblocker still blocks the mp_integration file based on content.

Related issues

closes #165

@SebastianStamm SebastianStamm requested a review from saig0 as a code owner April 4, 2023 09:49
saig0
saig0 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianStamm looks good. 👍

@saig0 saig0 merged commit 6581db7 into main Apr 4, 2023
@saig0 saig0 deleted the 165-adblocker branch April 4, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ad-Blocker breaks functionality
2 participants
@SebastianStamm @saig0