fix: Show Zeebe-Play version #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Zeebe-Play version is always "dev" if it is used as a Docker image. The common way with the manifest file (generated by the JAR plugin) doesn't work because Jib doesn't use the JAR but the class files directly. Solve this issue by using a special file to store the version on building the artifact. By using the JAR, it should fix the issue that the Zeebe-Play version is not shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Zeebe-Play version is always "dev" if it is used as a Docker image. The common way with the manifest file (generated by the JAR plugin) doesn't work because Jib doesn't use the JAR but the class files directly.
Solve this issue by using a special file to store the version on building the artifact. By using the JAR, it should fix the issue that the Zeebe-Play version is not shown.
Related issues