Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: break long variable values in code blocks #201

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

SebastianStamm
Copy link
Collaborator

@SebastianStamm SebastianStamm commented May 4, 2023

Description

Long variables broke the layout, not only in the incident modal, but also in the variables tab. I decided to add the rule to the general code tag in alignment with the rules established by Bootstrap here:

code {
font-size: 0.875em;
color: #d63384;
word-wrap: break-word;
}

Related issues

contributes to #193

@SebastianStamm SebastianStamm requested a review from saig0 as a code owner May 4, 2023 09:17
Copy link
Collaborator

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastianStamm I'm not sure if the issue is already solved.

I tested the issue with a process instance that contains long variables. If I look at the variables in the incident modal, it looks still broken.

image

@SebastianStamm
Copy link
Collaborator Author

I cannot reproduce this issue. I have used the linked process and filled the pull_requests variable with a long JSON (because I did not want to setup the connector). Both on Chrome and Firefox the value field wraps correctly:

image

@saig0
Copy link
Collaborator

saig0 commented May 16, 2023

@SebastianStamm weird. I still face this issue. Let's have a look together. 👀

@saig0 saig0 self-requested a review May 16, 2023 11:13
Copy link
Collaborator

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at it together, we saw that the change doesn't fix the issue completely but improves the situation. We merge the PR to make progress. 🚀

@saig0 saig0 merged commit a6c69d5 into main May 16, 2023
@saig0 saig0 deleted the 193-variable-wrap branch May 16, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants