feat(UI): forward Zeebe client exceptions to the web UI #353
Conversation
new: allow multiple errors, info and success messages displayed at once fix: closing error panel also closes info panel (now each panel must be closed individually) change: when during incident resolving the job can't be changed, there's still an attempt to resolve the incident
nitram509
changed the title
|
Hi @saig0, without raising any pressure, may I ask for a brief reflection/feedback on this PR, please? |
There was a problem hiding this comment.
@nitram509 great contribution 🎉 Thank you 👍
It looks good. I just have two minor comments. Please have a look.
skip duplicate messages see comments in camunda-community-hub#353
|
@saig0 I've pushed changes according to your feedback. thanks for that. |
|
@nitram509 should I build a new version? Or, do you have more changes planned? |
@saig0 there's one more ... during performance testing of zeebe, I run into the issue, that the process instance details page was too large and crashed chrome & also some timing-related issues in Spring/Async/Response let to HTML source in my browser looks messed up (= html head/title at the bottom, very weird). I plan to introduce pagination in the details view, since my best guess is, that 1000+ table rows for audit logs are simply too large to handle. |
Motivation
Using Simple Monitor during development is somehow awkward because e.g. BPMN errors during deployment,
or actions like "resolve incident" do not show underlying Zeebe errors.
This PR attempts to improve this by a) enabling multiple errors shown at once and b) actively pushing ZeebeClientException messages to the UI.
Change Summary
example screenshot, how multiple errors are visualized...
PS: there's one related change, I hope this is OK to be in here as well...
when clicking "resolve incident" in the backend two commands are sent to Zeebe. that's not obvious and slightly differs from e.g. using the CLI. So I adopted the implementation, that the second command is always fired, no matter if "update retries" fails, the resolve command is fired too. (I hope this helps hunt down the issue when Zeebe's housekeeping kicks in and Simple Monitor's data is no more in synch.)