Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): incident view filtering by process id and time #457

Merged
merged 5 commits into from
Dec 20, 2022
Merged

feat(ui): incident view filtering by process id and time #457

merged 5 commits into from
Dec 20, 2022

Conversation

nitram509
Copy link
Collaborator

implements #438

Demo/Screenshot

Screenshot 2022-10-05 at 16 45 13

noteworthy changes

  • introducing new dependencies for QueryDSL
    • reasoning QueryDSL is well supported with the Spring JPA framework and eases the filtering of various attributes
  • there's a bug fix for popper.js, since the import was broken (visible in JS console of Chrome, when clicking a drop-down menu, created with bootstrap and then there was the error message, that popper.js was missing)
  • on-top of the ticket, I do introduce sorting of error type and process id to further assist in finding incidents

@saig0 saig0 self-requested a review October 10, 2022 05:19
@saig0
Copy link
Contributor

saig0 commented Oct 10, 2022

@nitram509 thank you for your contribution. 🎉 I'll have a look at your PR in the next few days. 👀

@nitram509
Copy link
Collaborator Author

@saig0 I did an update, including the latest changes from main.

What's your view on this PR?

@saig0
Copy link
Contributor

saig0 commented Dec 16, 2022

@nitram509 I'll have a look at your PR next week.

saig0
saig0 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitram509 very cool. 🎉 I like it. 👍

@nitram509 nitram509 merged commit dbb62a1 into camunda-community-hub:main Dec 20, 2022
@nitram509 nitram509 deleted the issue/438-incident-view-filtering branch December 20, 2022 12:30
@nitram509 nitram509 restored the issue/438-incident-view-filtering branch February 15, 2023 14:00
@nitram509 nitram509 deleted the issue/438-incident-view-filtering branch March 17, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitram509 @saig0