Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added context-path support #103

Merged
merged 2 commits into from
Oct 15, 2022

Conversation

skayliu
Copy link
Contributor

@skayliu skayliu commented Sep 15, 2022

we can now have zeebe-simple-takslist running on a different path then / by setting:
server.servlet.context-path=/tasklist/

closes issues#38

@skayliu
Copy link
Contributor Author

skayliu commented Sep 15, 2022

Hi,@saig0, I've added context-path support, please have a review it, thank you.

@saig0 saig0 self-requested a review September 16, 2022 03:58
@saig0
Copy link
Contributor

saig0 commented Sep 16, 2022

@skayliu awesome. 🎉 Thank you for contributing. 🚀

Please note that I'm less available at the moment. It might take two weeks before a can have a look at your changes.

Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skayliu nice. 🎉 The changes look good. 👍

But the notifications don't work anymore. The UI doesn't show a notification if a new task is added or canceled. Maybe, you need to adjust WebSocketConfig too. Please have a look. 🍪

image

@skayliu
Copy link
Contributor Author

skayliu commented Oct 14, 2022

Hi, @saig0, It's done , please check this out.

@skayliu skayliu requested a review from saig0 October 14, 2022 10:10
Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skayliu awesome. 🎉

Your PR is ready to merge. 🚀

@saig0 saig0 merged commit 349f8c3 into camunda-community-hub:main Oct 15, 2022
@skayliu skayliu deleted the 38-context-path-support branch October 18, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change context-path not working as expected
2 participants