Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests against TC Cloud #273

Merged
merged 8 commits into from
May 25, 2022
Merged

Run all tests against TC Cloud #273

merged 8 commits into from
May 25, 2022

Conversation

npepinpe
Copy link
Collaborator

@npepinpe npepinpe commented Apr 20, 2022

Description

This PR runs all tests against TestContainers Cloud instead of the local Docker daemon. This allows us to greatly increase the execution parallelism, and reduce the length of the runs from 10 minutes to 3-4 minutes.

One of the changes that was required to make sure tests are not flaky is that all clustered tests should run in their own networks, as otherwise you may end up seeing nodes talking to each other across tests.

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing
  • Ensure all PR checks are green

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022

CLA assistant check
All committers have signed the CLA.

@npepinpe
Copy link
Collaborator Author

It seems if I push the parallelism eventually containers fail to startup 😄

@npepinpe npepinpe force-pushed the np-tc-cloud branch 2 times, most recently from 589b05d to 418c672 Compare April 27, 2022 14:31
Additionally, enable parallelism for all tests when using the
parallel-test profile.
@npepinpe npepinpe force-pushed the np-tc-cloud branch 2 times, most recently from 73a9365 to 3b72f4e Compare May 25, 2022 08:24
@npepinpe npepinpe marked this pull request as ready for review May 25, 2022 08:26
@npepinpe npepinpe merged commit 82136b2 into main May 25, 2022
@npepinpe npepinpe deleted the np-tc-cloud branch May 25, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants