Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21 update for Zeebe 0.22.1 final #35

Merged
2 commits merged into from
Feb 3, 2020
Merged

#21 update for Zeebe 0.22.1 final #35

2 commits merged into from
Feb 3, 2020

Conversation

grexe
Copy link
Contributor

@grexe grexe commented Jan 24, 2020

  • removed alpha versions, all supported versions are final now
  • WIP: tests run through in IDE, but not on command line -> container timeouts for cluster tests
  • storing version in ZeebeBrokerContainer so we can retrieve the correct log output (stored in Enum now)
  • moved SupportedVersion to make it accessible from both test and implementation

@grexe
#21 update for Zeebe 0.22.1 final
072a96e 
- removed alpha versions, all supported versions are final now
- WIP: tests run through in IDE, but not on command line -> container timeouts for cluster tests
- storing version in ZeebeBrokerContainer so we can retrieve the correct log output (stored in Enum now)
- moved SupportedVersion to make it accessible from both test and implementation
@claassistantio
Copy link

claassistantio commented Jan 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Jan 29, 2020
Closed
Closed
@npepinpe
Copy link
Collaborator

npepinpe commented Jan 29, 2020 •
edited
Loading

I checked out your branch, and I can confirm the tests don't time out on Linux or Windows 10 (CLI or IntelliJ) - so maybe it is a macOS issue? You could try adding the following to the .travis.yml if you want to have some external confirmation:

os:
  - linux
  - osx

(see https://docs.travis-ci.com/user/multi-os/)

As far as I'm concerned though, if the tests are passing on Travis, and later on our own Jenkins CI, and on Windows and Linux, I'm satisfied with this.

@npepinpe
Copy link
Collaborator

If you can just rebase, and sign the CLA, then I will gladly merge this 👍

To sign the CLA, the git email used to commit must be the same as your GitHub user (or just that email as well to your Github account).

@npepinpe npepinpe added the type/feature New user facing features label Jan 29, 2020
@npepinpe npepinpe self-assigned this Jan 29, 2020
@npepinpe npepinpe self-requested a review January 29, 2020 14:40
@npepinpe npepinpe assigned grexe and unassigned npepinpe Jan 29, 2020
@grexe
Copy link
Contributor Author

grexe commented Jan 29, 2020

Thanks, I'm still waiting for the OK by my boss but it's more of a formal check, will do!

@grexe
Copy link
Contributor Author

grexe commented Feb 3, 2020

I've signed the CLA now and resolved the merge conflict of my PR (framework versions have been updated in the meantime).

npepinpe
npepinpe approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@npepinpe npepinpe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I want to merge a fix for #38 (should take a few minutes only) and then will release 🎉

@npepinpe
Copy link
Collaborator

npepinpe commented Feb 3, 2020

bors r+

ghost pushed a commit that referenced this pull request Feb 3, 2020
@grexe
Merge #35
d83e0f0 
35: #21 update for Zeebe 0.22.1 final r=npepinpe a=grexe

- removed alpha versions, all supported versions are final now
- WIP: tests run through in IDE, but not on command line -> container timeouts for cluster tests
- storing version in ZeebeBrokerContainer so we can retrieve the correct log output (stored in Enum now)
- moved SupportedVersion to make it accessible from both test and implementation

Co-authored-by: Gregor B. Rosenauer <gregor.rosenauer@viesure.io>
Co-authored-by: Gregor B. Rosenauer <gregor.rosenauer@gmail.com>
@ghost
Copy link

ghost commented Feb 3, 2020

Build succeeded

@ghost ghost merged commit 73b07c9 into camunda-community-hub:master Feb 3, 2020
@npepinpe npepinpe mentioned this pull request Feb 3, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npepinpe npepinpe npepinpe approved these changes

Assignees

@grexe grexe

Labels
type/feature New user facing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grexe @claassistantio @npepinpe