chore(containers): improve wait strategy #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
approved these changes
Feb 7, 2020
npepinpe
reviewed
Feb 7, 2020
npepinpe
added
type/maintenance
miguelpires
force-pushed
the
37-wait-strategy
branch
from
e662306 to
6747e1c
Compare
|
bors r+ |
ghost
pushed a commit
that referenced
this pull request
Feb 7, 2020
41: chore(containers): improve wait strategy r=MiguelPires a=MiguelPires ## Description Changes the wait strategy to wait for a 204 response from the `/ready` endpoint and for the command API to be ready to accept commands. This has the advantage of not being dependent on broker logs and expanding the supported zeebe versions from 0.20.1, 0.21.1 and 0.22.1 to all versions that support the `/ready` endpoint on the 9600 port. It's also possible to use zeebe-test-container with non semver version like SNAPSHOT. ## Related issues closes #37 ## Pull Request Checklist - [x] All commit messages match our [commit message guidelines](https://github.com/zeebe-io/zeebe/blob/develop/CONTRIBUTING.md#commit-message-guidelines) - [x] The submitting code follows our [code style](https://github.com/zeebe-io/zeebe/wiki/Code-Style) - [x] If submitting code, please run `mvn clean install -DskipTests` locally before committing Co-authored-by: Miguel Pires <miguel.pires@camunda.com>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the wait strategy to wait for a 204 response from the
/readyendpoint and for the command API to be ready to accept commands. This has the advantage of not being dependent on broker logs and expanding the supported zeebe versions from 0.20.1, 0.21.1 and 0.22.1 to all versions that support the/readyendpoint on the 9600 port. It's also possible to use zeebe-test-container with non semver version like SNAPSHOT.Related issues
closes #37
Pull Request Checklist
mvn clean install -DskipTestslocally before committing