Skip to content

Commit

Permalink
fix(repo): fix example in README
Browse files Browse the repository at this point in the history
Give a correct example constructor of Camunda8 in the README

fixes #153
  • Loading branch information
jwulf committed May 7, 2024
1 parent 09cd2a1 commit 1ad1576
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
- name: Build
run: npm run build

- name: Build and Smoke Test
run: npm run test:smoketest

- name: Run Unit Tests
run: |
npm run test
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ Here is an example of specifying a different cache directory via the constructor
import { Camunda8 } from '@camunda8/sdk'

const c8 = new Camunda8({
config: {
CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache',
},
CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache',
})
```

Expand Down Expand Up @@ -149,7 +147,6 @@ Here is an example of doing this via the constructor, rather than via the enviro
import { Camunda8 } from '@camunda8/sdk'

const c8 = new Camunda8({
config: {
ZEEBE_ADDRESS: 'localhost:26500'
ZEEBE_CLIENT_ID: 'zeebe'
ZEEBE_CLIENT_SECRET: 'zecret'
Expand All @@ -160,7 +157,6 @@ const c8 = new Camunda8({
CAMUNDA_MODELER_BASE_URL: 'http://localhost:8070/api'
CAMUNDA_TENANT_ID: '' // We can override values in the env by passing an empty string value
CAMUNDA_SECURE_CONNECTION: false
}
})
```

Expand Down

0 comments on commit 1ad1576

Please sign in to comment.