Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable checkbox disables after deleting diagram with pool #149

Closed
Camundaan opened this issue Jul 26, 2022 · 4 comments · Fixed by #159
Closed

Executable checkbox disables after deleting diagram with pool #149

Camundaan opened this issue Jul 26, 2022 · 4 comments · Fixed by #159
Assignees
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Camundaan
Copy link

Describe the Bug
After deleting the last pool with a working diagram in the WebModeler, the "executable" checkbox is automatically disabled and stays disabled even after creating an error-free diagram after that.

Steps to Reproduce
Recording
Passcode: c@4R?Sp*

  1. Create a working diagram in a pool
  2. Delete pool
  3. Checkbox "executable" is disabled and stays disabled even when users create a new working, error-free diagram.

Expected Behavior
Users would expect the executable checkbox to be automatically enabled again when creating a new diagram, with or without a pool.

Environment
WebModeler

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Modeler version: [e.g. 2.0.0]
@Camundaan Camundaan added the bug Something isn't working label Jul 26, 2022
@marstamm
Copy link
Member

I can reproduce this also on latest modeler release.

Root Cause

When the last participant is deleted, bpmn-js replaces the collaboration with an empty process without any execution semantics.

This might be a case to be fixed in https://github.com/camunda/camunda-bpmn-js-behaviors to keep the config of the last Process

@marstamm marstamm added the backlog Queued in backlog label Jul 28, 2022
@christian-konrad
Copy link

@marstamm can I add this to ready, so we can discuss this in the next planning?

@marstamm marstamm added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 29, 2022
@marstamm
Copy link
Member

@christian-konrad, I moved it to ready. You can move any issue to ready that you want to discuss in the next planning meeting. no need to check in first :)

@christian-konrad christian-konrad added the spring cleaning Could be cleaned up one day label Aug 2, 2022
@christian-konrad christian-konrad added the backlog Queued in backlog label Aug 2, 2022 — with bpmn-io-tasks
@christian-konrad christian-konrad removed the ready Ready to be worked on label Aug 2, 2022
@marstamm marstamm self-assigned this Aug 15, 2022
@marstamm marstamm added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Aug 16, 2022
pinussilvestrus pushed a commit that referenced this issue Sep 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Sep 1, 2022
@pinussilvestrus pinussilvestrus removed their assignment Sep 1, 2022
@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Sep 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Sep 2, 2022
merge-me bot pushed a commit that referenced this issue Sep 2, 2022
@pinussilvestrus
Copy link
Contributor

Closed via 2935865

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants