Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest element ID instead of name for variable suggestions #83

Closed
barmac opened this issue Oct 23, 2023 · 2 comments · Fixed by #86
Closed

Suggest element ID instead of name for variable suggestions #83

barmac opened this issue Oct 23, 2023 · 2 comments · Fixed by #86
Assignees
@barmac
Labels
enhancement New feature or request

Comments

@barmac
Copy link
Collaborator

barmac commented Oct 23, 2023

Is your feature request related to a problem? Please describe.

In Camunda, expressions have to use element ID (specifically decision ID) in order to reference variables.
Currently, the editor suggests element name which is contrary to the engine implementation, even though it's the way it's specified in DMN.

Describe the solution you'd like

Variable suggestions should use element ID. They can optionally provide element name in description.

Describe alternatives you've considered

Change the engine implementation.

Additional context
@barmac barmac added enhancement New feature or request ready Ready to be worked on labels Oct 23, 2023
@barmac barmac self-assigned this Oct 23, 2023
@barmac
Copy link
Collaborator Author

barmac commented Nov 7, 2023

I reached out to DMN experts to clarify this: https://camunda.slack.com/archives/C01QYD808A3/p1699368885971839

@barmac
Copy link
Collaborator Author

barmac commented Nov 9, 2023

Conclusion: We are following up with this as for now.

@barmac barmac added the in progress Currently worked on label Nov 22, 2023 — with bpmn-io-tasks
@barmac barmac removed the ready Ready to be worked on label Nov 22, 2023
barmac added a commit to bpmn-io/dmn-variable-resolver that referenced this issue Nov 22, 2023
@barmac
feat: provide origin as ID of element defining variable
09aca5d 
Related to camunda/camunda-dmn-js#83
@barmac barmac mentioned this issue Nov 22, 2023
Merged
barmac added a commit to bpmn-io/dmn-variable-resolver that referenced this issue Nov 23, 2023
@barmac
feat: provide origin as element defining variable
00a4b5f 
Related to camunda/camunda-dmn-js#83
barmac added a commit that referenced this issue Nov 23, 2023
@barmac
feat: suggest element id as variable name
9a59036 
Closes #83
@barmac barmac mentioned this issue Nov 23, 2023
Merged
fake-join bot pushed a commit to bpmn-io/dmn-variable-resolver that referenced this issue Nov 28, 2023
@barmac @fake-join
feat: provide origin as element defining variable
9ffaa7a 
Related to camunda/camunda-dmn-js#83
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 30, 2023
@barmac
deps: update to @bpmn-io/dmn-variable-resolver@0.4.0
06b760d 
Related to camunda/camunda-dmn-js#83
@barmac barmac mentioned this issue Nov 30, 2023
Merged
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 30, 2023
@barmac
deps: update to @bpmn-io/dmn-variable-resolver@0.4.0
b497476 
Related to camunda/camunda-dmn-js#83
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 30, 2023
@barmac
deps: update to @bpmn-io/dmn-variable-resolver@0.4.0
9d5f4e9 
Related to camunda/camunda-dmn-js#83
barmac added a commit that referenced this issue Nov 30, 2023
@barmac
feat: suggest element id as variable name
496f68d 
deps: update to `dmn-js@14.7.1`

Closes #83
barmac added a commit that referenced this issue Nov 30, 2023
@barmac
feat: suggest element id as variable name
1a17018 
deps: update to `dmn-js@14.7.1`

Closes #83
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 30, 2023
@barmac barmac closed this as completed in #86 Dec 1, 2023
barmac added a commit that referenced this issue Dec 1, 2023
@barmac
feat: suggest element id as variable name
7de8237 
deps: update to `dmn-js@14.7.1`

Closes #83
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 1, 2023
@smbea smbea mentioned this issue Dec 5, 2023
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest element id as variable name camunda/camunda-dmn-js
1 participant
@barmac