-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector template generator #4382
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
@mesellings could you please review this PR? The feature is already in PROD since the 15th of October, and I have to provide penetration test scenarios where I need to refer to the doc as well |
Hi @markfarkas-camunda we're currently away in the US for our team meeting this week, but I will try and take a look this morning before and after the meeting today, otherwise it will be on Monday 👍 |
@markfarkas-camunda I'm confused when you say this has been in PROD since October 15th, but the PR description says it's part of an alpha or minor, and labeled for 8.7. Could you or @mesellings update the description (and possibly the label) to indicate this should be reviewed and released ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YanaSegal I have reviewed and made comprehensive changes to the doc, but happy with it - great initial work 👍 There is probably some follow-up work to add some more inter-linking to this across the docs (possibly) but I will look at this with the new Connectors work 👍
@markfarkas-camunda @YanaSegal Can I just clarify:
|
@mesellings this feature is in prod for SaaS, but not yet for self-managed. In this case shall we add the doc also to 8.6 docs? |
@markfarkas-camunda We can add a 'SaaS only' badge to the page until it is available for SM - if it's available in 8.6 for SaaS then we can/should add it there? |
@markfarkas-camunda I have added a "SaaS only" badge to the top of the page, and backported for the 8.6 docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - approved 👍
🧹 Preview environment for this PR has been torn down. |
1 similar comment
🧹 Preview environment for this PR has been torn down. |
Description
This feature has been release to prod for SaaS users, and will be release with next alpha for SM users.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).