Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector template generator #4382

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Connector template generator #4382

merged 9 commits into from
Nov 1, 2024

Conversation

YanaSegal
Copy link
Contributor

@YanaSegal YanaSegal commented Oct 2, 2024

Description

This feature has been release to prod for SaaS users, and will be release with next alpha for SM users.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Oct 2, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@YanaSegal YanaSegal self-assigned this Oct 2, 2024
@YanaSegal YanaSegal added component:docs Documentation improvements, including new or updated content target:8.7 Issues included in the 8.7 release labels Oct 2, 2024
@mesellings mesellings self-assigned this Oct 2, 2024
@markfarkas-camunda
Copy link
Contributor

@mesellings could you please review this PR? The feature is already in PROD since the 15th of October, and I have to provide penetration test scenarios where I need to refer to the doc as well

@mesellings
Copy link
Contributor

Hi @markfarkas-camunda we're currently away in the US for our team meeting this week, but I will try and take a look this morning before and after the meeting today, otherwise it will be on Monday 👍

@mesellings mesellings added deploy Stand up a temporary docs site with this PR kind/feature Issues related with features to be documented component:connectors Issues related to the connectors project. component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS labels Oct 25, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs October 25, 2024 20:23 Destroyed
@akeller
Copy link
Member

akeller commented Oct 25, 2024

@markfarkas-camunda I'm confused when you say this has been in PROD since October 15th, but the PR description says it's part of an alpha or minor, and labeled for 8.7. Could you or @mesellings update the description (and possibly the label) to indicate this should be reviewed and released ASAP.

mesellings
mesellings previously approved these changes Oct 25, 2024
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanaSegal I have reviewed and made comprehensive changes to the doc, but happy with it - great initial work 👍 There is probably some follow-up work to add some more inter-linking to this across the docs (possibly) but I will look at this with the new Connectors work 👍

@mesellings mesellings requested a review from a team October 25, 2024 22:53
@github-actions github-actions bot temporarily deployed to camunda-docs October 25, 2024 23:08 Destroyed
@mesellings
Copy link
Contributor

@markfarkas-camunda @YanaSegal Can I just clarify:

  • This is not in prod for 8.6, so will need this doc added to the 8.6 docs (rather than just Next and 8.7)
  • Can you adjust the labels from 8.7 to the relevant version if this is the case please?

@markfarkas-camunda
Copy link
Contributor

@mesellings this feature is in prod for SaaS, but not yet for self-managed. In this case shall we add the doc also to 8.6 docs?

@mesellings
Copy link
Contributor

mesellings commented Oct 28, 2024

@markfarkas-camunda We can add a 'SaaS only' badge to the page until it is available for SM - if it's available in 8.6 for SaaS then we can/should add it there?

@mesellings
Copy link
Contributor

@markfarkas-camunda I have added a "SaaS only" badge to the top of the page, and backported for the 8.6 docs.
Please re-review and approve if you're happy for the docs to go live 👍 (@YanaSegal only review if you need to).

@github-actions github-actions bot temporarily deployed to camunda-docs October 30, 2024 17:52 Destroyed
@mesellings mesellings self-requested a review November 1, 2024 16:10
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - approved 👍

@github-actions github-actions bot temporarily deployed to camunda-docs November 1, 2024 16:27 Destroyed
@mesellings mesellings merged commit f70c568 into main Nov 1, 2024
7 checks passed
@mesellings mesellings deleted the Connector-template-genrator branch November 1, 2024 17:19
@mesellings mesellings removed target:8.7 Issues included in the 8.7 release deploy Stand up a temporary docs site with this PR labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🧹 Preview environment for this PR has been torn down.

1 similar comment
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. component:docs Documentation improvements, including new or updated content component:web-modeler-SaaS Continuous delivery - Issues related with Web Modeler SaaS kind/feature Issues related with features to be documented
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants