Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camunda REST API doc #4534

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update camunda REST API doc #4534

merged 5 commits into from
Oct 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Description

This is an autogenerated PR by the sync api specs workflow.
This PR contains every changes made to the REST api specs in the monorepo in the last week.
This PR contains also all the generated OpenAPI files related to the changes.

When should this change go live?

  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for the next minor and are in /docs directory (aka /next/).
  • My changes require a technical writer review, and I've assigned @camunda/tech-writers as a reviewer.

@github-actions github-actions bot added the deploy Stand up a temporary docs site with this PR label Oct 29, 2024
@pepopowitz pepopowitz self-requested a review October 29, 2024 20:59
@pepopowitz pepopowitz self-assigned this Oct 29, 2024
Copy link
Contributor Author

github-actions bot commented Oct 29, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/apis-tools/camunda-api-rest/camunda-api-rest-authentication.md
  • docs/apis-tools/camunda-api-rest/camunda-api-rest-overview.md
  • docs/apis-tools/camunda-api-rest/specifications/activate-jobs.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/assign-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/broadcast-signal.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/cancel-process-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/complete-job.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/complete-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/correlate-message.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-deployment.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-document-link.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-document.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-element-instance-variables.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-process-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/create-user.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/delete-document.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/delete-resource.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/evaluate-decision.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/fail-job.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-authorizations.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-decision-definitions.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-decision-instances.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-decision-requirements.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-flow-node-instances.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-incidents.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-process-definitions.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-process-instances.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-user-task-variables.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-user-tasks.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-users.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/find-variables.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-decision-definition-xml.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-decision-definition.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-decision-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-decision-requirements-xml.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-decision-requirements.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-document.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-flow-node-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-incident.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-license.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-process-definition-xml.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-process-definition.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-process-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-start-process-form.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-topology.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-user-task-form.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/get-variable.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/migrate-process-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/modify-process-instance.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/pin-clock.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/publish-message.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/report-job-error.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/reset-clock.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/resolve-incident.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/sidebar.js
  • docs/apis-tools/camunda-api-rest/specifications/unassign-user-task.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/update-authorization.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/update-job.api.mdx
  • docs/apis-tools/camunda-api-rest/specifications/update-user-task.api.mdx
  • docs/components/concepts/messages.md
  • docs/reference/release-notes/860.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I thought I posted this already?)

Several things to duplicate upstream, which I'll take care of after this merges.

Comment on lines +28 to +48
tags:
- name: Authorization
- name: Clock
- name: Cluster
- name: Decision definition
- name: Decision instance
- name: Decision requirements
- name: Document
- name: Element instance
- name: Flow node instance
- name: Incident
- name: Job
- name: License
- name: Message
- name: Process definition
- name: Process instance
- name: Resource
- name: Signal
- name: User
- name: User task
- name: Variable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

As @tmetzke pointed out in the PR at the source, a side-effect of defining these tags is that the sidebar nav will always generate in this order.

responses:
"200":
description: >
The user task varialbes search successful response.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The user task varialbes search successful response.
The user task variables search successful response.

spelling error. I'll correct this at the source.

summary: Pin internal clock (alpha)
description: |
Set a precise, static time for the Zeebe engine’s internal clock.
When the clock is pinned, it remains at the specified time and does not advance.
To change the time, the clock must be pinned again with a new timestamp.

:::note
This endpoint is an [alpha feature](/components/early-access/alpha/alpha-features.md) and may be subject to change
This endpoint is an [alpha feature](/reference/alpha-features.md) and may be subject to change
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverting changes in #4465. I'll need to adjust this in this in this PR, because it is a broken link. I'll also propagate the changes from #4465 upstream.

@christinaausley @akeller FYI this is the kind of change that needs to be duplicated in the camunda/camunda repo, or else it's going to be wiped out every time the API docs are re-generated.

paths:
/topology:
get:
tags:
- Cluster
operationId: getTopology
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, adding operationIds to the endpoints causes them to generate in a different file path. This isn't a problem, just not something I was expecting.

I will make a note for myself in the htaccess as part of this PR, pointing back here, because at time of the next release I will need to create a bunch of redirect rules for everything that moved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I should have given you a heads-up, I missed that. The long-term benefit with this is: the file path and URL is now based on the operation id instead of the path summary (which can easily change). Thus, URLs will be more stable from now on.

@github-actions github-actions bot temporarily deployed to camunda-docs October 29, 2024 21:49 Destroyed
@pepopowitz pepopowitz merged commit 977189a into main Oct 29, 2024
7 checks passed
@pepopowitz pepopowitz deleted the update-rest-doc branch October 29, 2024 21:58
@pepopowitz
Copy link
Collaborator

Changes made upstream in camunda/camunda#24190.

Copy link
Contributor Author

🧹 Preview environment for this PR has been torn down.

Comment on lines +3 to +6
# Disclaimer: This is a modified version of the Camunda REST API specification, optimized for the documentation.

# Disclaimer: This is a modified version of the Camunda REST API specification, optimized for the documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting that we have this duplicated in here now 😅
Not a big deal, of course, it's just a comment in the spec file in the docs, not the source.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, fun! I know why that happened. I re-generated the docs in this branch, and it added that comment both times.

I'll fix this for the future!

github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Oct 30, 2024
## Description

Pulls multiple changes discussed in
camunda/camunda-docs#4534 into the OpenAPI spec.
github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Oct 30, 2024
## Description

Pulls multiple changes discussed in
camunda/camunda-docs#4534 into the OpenAPI spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants