Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use real, actual javascript in api generators #4788

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

pepopowitz
Copy link
Collaborator

Description

While investigating #3736, I discovered that the error handling in the API generator code doesn't actually run 😰.

This is not really a significant issue because the only way to find it is to improperly call the API generators, but it's probably better to actually tell people how they're misusing them.

For what it's worth, I'm pretty sure GitHub Copilot wrote these blocks for me, demonstrating again that computers should never be trusted.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@pepopowitz pepopowitz requested a review from akeller December 17, 2024 21:41
@pepopowitz pepopowitz self-assigned this Dec 17, 2024
@pepopowitz pepopowitz added kind/bug Issues related with bugs in the documentation dx Documentation infrastructure typically handled by the Camunda DX team labels Dec 17, 2024
@pepopowitz pepopowitz merged commit f2efb13 into main Dec 18, 2024
12 of 13 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/2719-proper-javascript branch December 18, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team kind/bug Issues related with bugs in the documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants