Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember authentication details with endpoint configuration #1067

Closed
1 task
nikku opened this issue Dec 11, 2018 · 4 comments · Fixed by #1526
Closed
1 task

Remember authentication details with endpoint configuration #1067

nikku opened this issue Dec 11, 2018 · 4 comments · Fixed by #1526
Assignees
@barmac
Labels
deploy
Milestone
M32

Comments

@nikku
Copy link
Member

nikku commented Dec 11, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.

As a user I am frustrated if I need to re-configure the authentication details every time I re-deploy a diagram.

Describe the solution you'd like

  • Deployment details, including authentication type (+ user name) (+ credentials ?) are stored within the user data config.json upon successful deployment and restored on deploy dialog re-open.

Describe alternatives you've considered

Don't store the details (password / token) if we don't find a way to secure it.
@nikku nikku added the deploy label Dec 11, 2018
@philippfromme philippfromme mentioned this issue Dec 11, 2018
Closed
58 tasks
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Dec 12, 2018
@pinussilvestrus pinussilvestrus mentioned this issue Dec 12, 2018
Closed
2 tasks
@nikku nikku mentioned this issue Jan 17, 2019
Closed
25 tasks
@nikku nikku mentioned this issue Jun 11, 2019
Closed
@nikku nikku added this to the M30 milestone Jul 8, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 8, 2019
@barmac barmac mentioned this issue Jul 24, 2019
Closed
9 tasks
@nikku nikku mentioned this issue Jul 26, 2019
Open
2 tasks
@nikku nikku modified the milestones: M30, M31 Aug 12, 2019
@barmac
Copy link
Collaborator

barmac commented Sep 23, 2019

I had a look at how VS Code Docker Extension handles the passwords and noticed that:

  • the passwords are stored in the system's keychain using https://github.com/atom/node-keytar
  • once the credentials are used they are kept in a session cache to not overuse the keychain

@barmac
Copy link
Collaborator

barmac commented Oct 1, 2019

Idea: Checkbox for remembering details

@barmac
Copy link
Collaborator

barmac commented Oct 1, 2019

Idea: Remember auth per endpoint url and the auth type.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Oct 9, 2019
@barmac barmac mentioned this issue Oct 9, 2019
Merged
9 tasks
barmac added a commit that referenced this issue Oct 10, 2019
@barmac
feat(deploy): remember authentication details
67ae3cf 
Closes #1067
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 10, 2019
@nikku nikku modified the milestones: M31, M32 Oct 15, 2019
@nikku nikku added ready Ready to be worked on and removed needs review Review pending labels Oct 15, 2019
@nikku
Copy link
Member Author

nikku commented Oct 15, 2019

Removed from #1439. We'll ship this with a future version of the tool.

barmac added a commit that referenced this issue Oct 21, 2019
@barmac
feat(deploy): remember authentication details
76a245d 
Closes #1067
barmac added a commit that referenced this issue Oct 21, 2019
@barmac
feat(deploy): remember authentication details
d52f479 
Closes #1067
@barmac barmac added needs review Review pending in progress Currently worked on and removed ready Ready to be worked on needs review Review pending labels Oct 21, 2019 — with bpmn-io-tasks
@nikku nikku added ready Ready to be worked on and removed in progress Currently worked on labels Oct 22, 2019 — with bpmn-io-tasks
nikku pushed a commit that referenced this issue Oct 31, 2019
@barmac @nikku
feat(deploy): remember authentication details
c2aee33 
Closes #1067
nikku pushed a commit that referenced this issue Nov 5, 2019
@barmac @nikku
feat(deploy): remember authentication details
1380f36 
Closes #1067
nikku pushed a commit that referenced this issue Nov 15, 2019
@barmac @nikku
feat(deploy): remember authentication details
e144cd9 
Closes #1067
nikku pushed a commit that referenced this issue Nov 18, 2019
@barmac @nikku
feat(deploy): remember authentication details
226c2e2 
Closes #1067
nikku pushed a commit that referenced this issue Nov 19, 2019
@barmac @nikku
feat(deploy): remember authentication details
48c77e8 
Closes #1067
@nikku nikku mentioned this issue Nov 20, 2019
Closed
51 tasks
nikku added a commit that referenced this issue Nov 22, 2019
@nikku
feat(deploy): remember authentication details
fe793cd 
* remember authentication details, if the user actively
  decides this
* restore global endpoint configuration, as intended until
  it is properly addressed via #804
* refactor deployment tool, pulling out validation into separate
  component
* pull out menu update functionality to be re-added at a later
  point in time, in a different place
* deployment tool UI remains untouched

Closes #1067
nikku added a commit that referenced this issue Nov 22, 2019
@nikku
feat(deploy): remember authentication details
85faa85 
* remember authentication details, if the user actively
  decides this
* restore global endpoint configuration, as intended until
  it is properly addressed via #804
* refactor deployment tool, pulling out validation into separate
  component
* pull out menu update functionality to be re-added at a later
  point in time, in a different place
* deployment tool UI remains untouched

Closes #1067
nikku added a commit that referenced this issue Nov 22, 2019
@nikku
feat(deploy): remember authentication details
1a22068 
* remember authentication details, if the user actively
  decides this
* restore global endpoint configuration, as intended until
  it is properly addressed via #804
* refactor deployment tool, pulling out validation into separate
  component
* pull out menu update functionality to be re-added at a later
  point in time, in a different place
* deployment tool UI remains untouched

Closes #1067
nikku added a commit that referenced this issue Nov 22, 2019
@nikku
feat(deploy): remember authentication details
5334c8a 
* remember authentication details, if the user actively
  decides this
* restore global endpoint configuration, as intended until
  it is properly addressed via #804
* refactor deployment tool, pulling out validation into separate
  component
* pull out menu update functionality to be re-added at a later
  point in time, in a different place
* deployment tool UI remains untouched

Closes #1067
@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels Nov 22, 2019 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2019
pinussilvestrus pushed a commit that referenced this issue Nov 22, 2019
@nikku
feat(deploy): remember authentication details
eb35b07 
* remember authentication details, if the user actively
  decides this
* restore global endpoint configuration, as intended until
  it is properly addressed via #804
* refactor deployment tool, pulling out validation into separate
  component
* pull out menu update functionality to be re-added at a later
  point in time, in a different place
* deployment tool UI remains untouched

Closes #1067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
deploy
Projects
None yet
Milestone
M32
Development

Successfully merging a pull request may close this issue.

Remember authentication details with endpoint configuration camunda/camunda-modeler
3 participants
@nikku @pinussilvestrus @barmac