Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EscalationEventDefinition#escalationRef lost on replace #1463

Closed
1 task
nikku opened this issue Aug 12, 2019 · 1 comment · Fixed by #1636
Closed
1 task

EscalationEventDefinition#escalationRef lost on replace #1463

nikku opened this issue Aug 12, 2019 · 1 comment · Fixed by #1636
Labels
BPMN bug Something isn't working modeling
Milestone
M33

Comments

@nikku
Copy link
Member

nikku commented Aug 12, 2019 •
edited by barmac
Loading

Describe the Bug

Making escalation boundary events non-interrupting should keep all configured properties, including the linked escalationRef is lost. Instead the reference is lost.

Steps to Reproduce

  • Open test diagram
  • Replace escalation boundary event with non-interrupting version
  • See that escalationRef is lost

Expected Behavior

  • EscalationEventDefinition#escalationRef is kept on replace

Environment

  • OS: Any
  • Camunda Modeler Version: v3.2.2, v3.3.0-alpha.1

Related to #1049
@nikku nikku mentioned this issue Aug 12, 2019
Closed
@falko falko mentioned this issue Aug 12, 2019
Closed
1 task
@nikku nikku added backlog Queued in backlog BPMN modeling bug Something isn't working labels Aug 12, 2019
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 21, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
183c7ba 
* copy references when copying element
* add referenced root element if it doesn't exist
* remove referenced root element once it's not referenced anymore

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 21, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
503458a 
* copy references when copying element
* add referenced root element if it doesn't exist
* remove referenced root element once it's not referenced anymore

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
@philippfromme philippfromme mentioned this issue Nov 21, 2019
Merged
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 21, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
e4149b9 
* copy references when copying element
* add referenced root element if it doesn't exist
* remove referenced root element once it's not referenced anymore

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 27, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
64a37da 
* copy references when copying element
* add referenced root element if it doesn't exist
* remove referenced root element once it's not referenced anymore

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 28, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
92e1d0b 
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 28, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
ed5a7d8 
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Nov 29, 2019
@philippfromme
feat(copy-paste): copy error, escalation, message and signal references
6a58935 
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
nikku pushed a commit to bpmn-io/bpmn-js that referenced this issue Nov 29, 2019
@philippfromme @nikku
feat(copy-paste): copy error, escalation, message and signal references
47b9930 
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
@nikku
Copy link
Member Author

nikku commented Nov 29, 2019

Fixed upstream via bpmn-io/bpmn-js#1245.

@nikku nikku added the fixed upstream Requires integration of upstream change label Nov 29, 2019
@nikku nikku added this to the M33 milestone Nov 29, 2019
@nikku nikku removed the backlog Queued in backlog label Nov 29, 2019
nikku pushed a commit to bpmn-io/bpmn-js that referenced this issue Dec 11, 2019
@philippfromme @nikku
feat(copy-paste): copy error, escalation, message and signal references
477217c 
* copy references when copying element
* add referenced root element if it doesn't exist
* do NOT add referenced root element if root element with same ID exists

Related to camunda/camunda-modeler#1049.
Related to camunda/camunda-modeler#1463.
nikku added a commit that referenced this issue Dec 16, 2019
@nikku
chore(client): bump to bpmn-js@6.1 / diagram-js@6.2
c5dcf2c 
Closes #1613
Closes #1463
Closes #1049
@nikku nikku mentioned this issue Dec 16, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Dec 16, 2019
@nikku nikku closed this as completed Dec 16, 2019
@nikku nikku removed the needs review Review pending label Dec 16, 2019 — with bpmn-io-tasks
Ichigo85 pushed a commit to sharedchains/camunda-modeler that referenced this issue Jan 10, 2020
@nikku @merge-me
chore(client): bump to bpmn-js@6.1 / diagram-js@6.2
2dae231 
Closes camunda#1613
Closes camunda#1463
Closes camunda#1049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN bug Something isn't working modeling
Projects
None yet
Milestone
M33
Development

Successfully merging a pull request may close this issue.

chore(client): bump to bpmn-js@6.1 / diagram-js@6.2 camunda/camunda-modeler
1 participant
@nikku