Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRD append does not work anymore #1604

Closed
nikku opened this issue Nov 25, 2019 · 1 comment
Closed

DRD append does not work anymore #1604

nikku opened this issue Nov 25, 2019 · 1 comment
Assignees
@philippfromme
Labels
bug Something isn't working DMN modeling
Milestone
M32

Comments

@nikku
Copy link
Member

nikku commented Nov 25, 2019 •
edited
Loading

Describe the Bug

Append from context pad does not work anymore, it worked in Camunda Modeler v3.4.1:

capture eRFlsF_optimized

Steps to Reproduce

  1. Model any element
  2. Try to append from context pad
  3. Element is created but connection is not

Expected Behavior

Append creates element and connection.

Environment

  • OS: Any
  • Camunda Modeler Version: 3.5.0-dev

This worked in Camunda Modeler v3.4.1.
@nikku nikku mentioned this issue Nov 25, 2019
Closed
51 tasks
@nikku nikku added bug Something isn't working DMN modeling labels Nov 25, 2019
@philippfromme philippfromme self-assigned this Nov 25, 2019
philippfromme added a commit to bpmn-io/dmn-js that referenced this issue Nov 25, 2019
@philippfromme
fix(context-pad): append to source
f19b6a0 
Related to camunda/camunda-modeler#1604
philippfromme added a commit to bpmn-io/dmn-js that referenced this issue Nov 25, 2019
@philippfromme
fix(context-pad): append to source
ed9388d 
Related to camunda/camunda-modeler#1604
nikku added a commit to bpmn-io/dmn-js that referenced this issue Nov 25, 2019
@nikku
fix(drd): correct append behavior
4c0a573 
+ test cover dat stuff

Related to camunda/camunda-modeler#1604
nikku added a commit to bpmn-io/dmn-js that referenced this issue Nov 25, 2019
@nikku
fix(drd): correct append behavior
17e8637 
+ test cover dat stuff

Related to camunda/camunda-modeler#1604
@nikku nikku mentioned this issue Nov 25, 2019
Merged
@nikku nikku added the needs review Review pending label Nov 25, 2019 — with bpmn-io-tasks
@nikku nikku added this to the M32 milestone Nov 25, 2019
fake-join bot pushed a commit to bpmn-io/dmn-js that referenced this issue Nov 26, 2019
@nikku @fake-join
fix(drd): correct append behavior
8896209 
+ test cover dat stuff

Related to camunda/camunda-modeler#1604
@philippfromme philippfromme added the fixed upstream Requires integration of upstream change label Nov 26, 2019
@nikku nikku removed the needs review Review pending label Nov 26, 2019 — with bpmn-io-tasks
@philippfromme
Copy link
Contributor

Closed via 62a50b1

@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working DMN modeling
Projects
None yet
Milestone
M32
Development

No branches or pull requests
2 participants
@nikku @philippfromme