Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source maps not working in Camunda Modeler crash reports #1831

Closed
2 tasks done
nikku opened this issue Jun 10, 2020 · 4 comments · Fixed by #1846
Closed
2 tasks done

Fix source maps not working in Camunda Modeler crash reports #1831

nikku opened this issue Jun 10, 2020 · 4 comments · Fixed by #1846
Assignees
Milestone

Comments

@nikku
Copy link
Member

nikku commented Jun 10, 2020

What should we do?

  • Investigate why source maps in the client bundle are not working in our crash reports. (See this comment.)
  • Fix the situation

Why should we do it?

Source maps allow us to reliably reproduce issues recorded.

@nikku nikku added infrastructure backlog Queued in backlog labels Jun 10, 2020
@oguzeroglu oguzeroglu self-assigned this Jun 10, 2020
@oguzeroglu oguzeroglu added in progress Currently worked on and removed backlog Queued in backlog labels Jun 19, 2020
@oguzeroglu
Copy link
Contributor

We should also not upload *Spec.js files, as they are now present within the uploaded artifacts in Sentry.

@oguzeroglu
Copy link
Contributor

We should also not set an array of plugins as a tag. It turns out that Sentry does not allow non-primivite values as tags:
Screenshot 2020-06-22 at 17 53 39

@oguzeroglu
Copy link
Contributor

We should also consider disabling this feature for nightlies, as we're uploading nightly sourcemaps to Sentry every night.

@oguzeroglu
Copy link
Contributor

oguzeroglu commented Jun 24, 2020

The problem seems to be path mismatch: Since we distribute the code to the clients, each error has a different path from uploaded sourcemap paths. We need to normalize the path before we send them to Sentry. I'm investigating the best practises for that.

This issue is similar to ours: https://forum.sentry.io/t/js-source-map-matching-with-wildcard-path/1871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants