DMN - Annotation flow disappears after renaming decision in table editor

[azeghers]

Describe the Bug

annotation-2021-01-06_14.48.59.mp4

Here are the logs after saving and reopening the diagram:

Steps to Reproduce

-Create Decision
-Name it
-Add Annotation
-Morph into Decision Table
-Rename inside of Decision Table mode
-Go back to DRD
-See that the Annotation is unlinked

Expected Behavior

The annotation stays linked to the decision element

Environment

• OS: Ubuntu 20.04
• Camunda Modeler Version: v4.5.0-rc.0

---

Related to #1874

[barmac]

Related to #1814 and #1763

I can also reproduce that in 4.4.0

[pinussilvestrus]

Related to #1874.

[philippfromme]

The issue is that when replacing the decision the association's parent from the model's perspective is changed to the text annotation. In the case of information requirements and such the parent is indeed the target element. Not in this case since the association is an artifact.

This issue was fixed before (bpmn-io/dmn-js@90a7952#diff-a42b136569b62592b63126d0bfe523df9cfd77884dfd10741252ceead428e185R265) but then broken again (bpmn-io/dmn-js@853eea1).

So we're fixing it again. ♻️

[nikku]

Fixed upstream (again) via bpmn-io/dmn-js#620.