Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, I'd like to know when an update check triggered by me fails #2086

Closed
barmac opened this issue Feb 5, 2021 · 3 comments · Fixed by #2216
Closed

As a user, I'd like to know when an update check triggered by me fails #2086

barmac opened this issue Feb 5, 2021 · 3 comments · Fixed by #2216
Assignees
@pinussilvestrus
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Milestone
M47

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 5, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

When I trigger update check and there are network problems or the update server responds with anything but 200, it fails silently and the user can only notice it via console.

Describe the solution you'd like

Show a notification on such problems.

Describe alternatives you've considered

Leave it as it is.
@barmac barmac added the enhancement New feature or request label Feb 5, 2021
@MaxTru MaxTru added the backlog Queued in backlog label Feb 5, 2021 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Feb 9, 2021
@pinussilvestrus pinussilvestrus self-assigned this Apr 16, 2021
pinussilvestrus pushed a commit that referenced this issue Apr 16, 2021
feat(update-checks): display errors
eaa4300 
Closes #2086
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Apr 16, 2021
@pinussilvestrus pinussilvestrus mentioned this issue Apr 16, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 16, 2021
@nikku
Copy link
Member

nikku commented Apr 16, 2021

As a user I'd expect that background update checks do not disturb be, cf. #2216 (comment). So my expectation is exactly the opposite of what you expect 😉.

pinussilvestrus pushed a commit that referenced this issue Apr 16, 2021
feat(update-checks): display errors
4fb4266 
Closes #2086
@barmac
Copy link
Collaborator Author

barmac commented Apr 16, 2021

I totally agree with you. Not sure why I did not specify it in the issue that I meant only the checks triggered by the user.

@barmac barmac changed the title As a user, I'd like to know when update check fails As a user, I'd like to know when an update check triggered by the user fails Apr 16, 2021
@barmac barmac changed the title As a user, I'd like to know when an update check triggered by the user fails As a user, I'd like to know when an update check triggered by me fails Apr 16, 2021
@pinussilvestrus pinussilvestrus added this to the M47 milestone Apr 20, 2021
@pinussilvestrus
Copy link
Contributor

Closed via #2216

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 20, 2021
philippfromme pushed a commit that referenced this issue May 10, 2021
@merge-me
feat(update-checks): display errors
0d51d9b 
Closes #2086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
M47
Development

Successfully merging a pull request may close this issue.

feat(update-checks): display errors camunda/camunda-modeler
4 participants
@nikku @pinussilvestrus @barmac @MaxTru