Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status bar disappears when log view is resized to max height #2258

Closed
andreasgeier opened this issue May 11, 2021 · 8 comments · Fixed by #2478
Closed

Status bar disappears when log view is resized to max height #2258

andreasgeier opened this issue May 11, 2021 · 8 comments · Fixed by #2478
Assignees
@philippfromme
Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day

Comments

@andreasgeier
Copy link

Describe the Bug

Status bar disappears when log view is resized to max height

Steps to Reproduce

  1. Open log view
  2. Resize log view to max height

--> Status bar disappears

Screen.Recording.2021-05-11.at.11.13.43.mov

Expected Behavior

The status bar should be a static part of the UI and shall not disappear or move.

Environment

  • OS: Mac OS 11.3.1
  • Camunda Modeler Version: 4.7.0-nightly.20210407
  • Installed plug-ins: cloud connect
@andreasgeier andreasgeier added the bug Something isn't working label May 11, 2021
@barmac
Copy link
Collaborator

barmac commented May 11, 2021

It happens because of no height limit for the log. Once it reaches some height, it starts to grow to the bottom. Then, the window can be scrolled.

So to fix the issue, we need a height limit for the log.

@pinussilvestrus pinussilvestrus added the ready Ready to be worked on label May 11, 2021
@pinussilvestrus pinussilvestrus added this to the M48 milestone Jun 7, 2021
@andreasgeier
Copy link
Author

As part of this bug fix you could also consider ensuring that the properties panel handler does not overlap the header but stays within the tab area.

@nikku nikku modified the milestones: M48, M49 Jul 5, 2021
@GeethaParthasarathy
Copy link

This issue also seems to occur with DMN as well. After expanding the logs, the DMN table goes completely inaccessible. We could not view the contents of the table and scroll through them as well.

DMN_logs.mp4

philippfromme added a commit to bpmn-io/form-js that referenced this issue Aug 16, 2021
@philippfromme
fix(editor): make palette, form and properties panel overflow scroll
365d578 
Related to camunda/camunda-modeler#2258
philippfromme added a commit to bpmn-io/form-js that referenced this issue Aug 16, 2021
@philippfromme
fix(editor): make palette, form and properties panel overflow scroll
bba783f 
Related to camunda/camunda-modeler#2258
philippfromme added a commit to bpmn-io/form-js that referenced this issue Aug 16, 2021
@philippfromme
fix(editor): make palette, form and properties panel overflow scroll
1b9c2d6 
Related to camunda/camunda-modeler#2258
fake-join bot pushed a commit to bpmn-io/form-js that referenced this issue Aug 16, 2021
@philippfromme @fake-join
fix(editor): make palette, form and properties panel overflow scroll
54ac244 
Related to camunda/camunda-modeler#2258
@MaxTru MaxTru removed this from the M49 milestone Aug 24, 2021
@nikku nikku added good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Sep 16, 2021
@ghost
Copy link

ghost commented Oct 11, 2021

Can I work on this issue?

@barmac
Copy link
Collaborator

barmac commented Oct 11, 2021

Yes, you can. Make sure to follow the contributing guidelines.

@ghost
Copy link

ghost commented Oct 11, 2021

Alright! Thanks! I would read and start ;)

@philippfromme philippfromme self-assigned this Oct 11, 2021
@philippfromme philippfromme added the in progress Currently worked on label Oct 11, 2021
philippfromme added a commit that referenced this issue Oct 11, 2021
@philippfromme
fix(client): restrict log height
84e0e5e 
* restrict log height to 50%
* position properties panel toggle absolutely

Closes #2258
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Oct 11, 2021
@philippfromme philippfromme mentioned this issue Oct 11, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 11, 2021
@philippfromme
Copy link
Contributor

@AsianCat54x Sorry, I didn't see your comment and already created a PR for this: #2478

@ghost
Copy link

ghost commented Oct 11, 2021 •
edited by ghost
Loading

Alright, I will leave this issue.

@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Oct 12, 2021 — with bpmn-io-tasks
philippfromme added a commit that referenced this issue Oct 12, 2021
@philippfromme
fix(client): restrict log height
cad2f17 
* refactor log for resizing to work like properties container resizing
* log has maximum height of 300

Closes #2258
philippfromme added a commit that referenced this issue Oct 12, 2021
@philippfromme
fix(client): restrict log height
9449bc6 
* refactor log for resizing to work like properties panel resizing
* log has maximum height of 300
* position properties panel toggle absolutely

Closes #2258
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 12, 2021
philippfromme added a commit that referenced this issue Oct 12, 2021
@philippfromme
fix(client): restrict log height
46fd002 
* refactor log for resizing to work like properties panel resizing
* log has maximum height of 300
* position properties panel toggle absolutely

Closes #2258
@nikku nikku added in progress Currently worked on and removed needs review Review pending labels Oct 13, 2021 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Oct 14, 2021
philippfromme added a commit that referenced this issue Oct 14, 2021
@philippfromme
fix(client): restrict log height
5972084 
* refactor log for resizing to work like properties panel resizing
* log has maximum height of 300
* position properties panel toggle absolutely

Closes #2258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client): restrict log height camunda/camunda-modeler
7 participants
@nikku @andreasgeier @philippfromme @pinussilvestrus @barmac @MaxTru @GeethaParthasarathy