Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Newline Characters Lost on Paste #2280

Closed
philippfromme opened this issue May 20, 2021 · 1 comment · Fixed by #2315
Closed

Windows Newline Characters Lost on Paste #2280

philippfromme opened this issue May 20, 2021 · 1 comment · Fixed by #2315
Labels
bug Something isn't working channel:support
Milestone
M48

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

Pasting copied text containing Windows newline characters (\r\n) results in those characters being lost. This affects both editing labels in the diagram and the properties panel. Both are using the API to paste the text (document.execCommand('insertText', false, 'foo')).

YiYfMJ831R

Steps to Reproduce

  1. Copy this text
Line 1

Line 3
  1. Paste text to edit label or into properties panel
  2. Empty line is lost due to Windows newline characters being lost

Expected Behavior

Newline characters are preserved regardless of operating system.

Environment

  • OS: Window 10
  • Camunda Modeler Version: 4.8.1

Jira Issue: https://jira.camunda.com/browse/SUPPORT-10754
@philippfromme philippfromme added bug Something isn't working ready Ready to be worked on labels May 20, 2021
philippfromme added a commit to bpmn-io/diagram-js-direct-editing that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
ba088af 
Related to camunda/camunda-modeler#2280
@philippfromme philippfromme mentioned this issue May 20, 2021
Merged
philippfromme added a commit to bpmn-io/diagram-js-direct-editing that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
e0e5da7 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
6c1ec10 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
7808b81 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/diagram-js-direct-editing that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
a128eaa 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
7b1300b 
Related to camunda/camunda-modeler#2280
@philippfromme philippfromme mentioned this issue May 20, 2021
Merged
fake-join bot pushed a commit to bpmn-io/diagram-js-direct-editing that referenced this issue May 20, 2021
@philippfromme @fake-join
fix: preserve Windows newline characters
528637d 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/dmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
d7553bf 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/dmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
bbdf13c 
Related to camunda/camunda-modeler#2280
philippfromme added a commit to bpmn-io/dmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme
fix: preserve Windows newline characters
4c89bad 
Related to camunda/camunda-modeler#2280
fake-join bot pushed a commit to bpmn-io/bpmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme @fake-join
fix: preserve Windows newline characters
aef0ead 
Related to camunda/camunda-modeler#2280
@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels May 20, 2021 — with bpmn-io-tasks
@philippfromme philippfromme mentioned this issue May 20, 2021
Merged
@philippfromme philippfromme added fixed upstream Requires integration of upstream change and removed needs review Review pending labels May 20, 2021 — with bpmn-io-tasks
fake-join bot pushed a commit to bpmn-io/dmn-js-properties-panel that referenced this issue May 20, 2021
@philippfromme @fake-join
fix: preserve Windows newline characters
09cdf49 
Related to camunda/camunda-modeler#2280
@nikku nikku added this to the M48 milestone May 20, 2021
barmac added a commit that referenced this issue Jun 17, 2021
@barmac
deps: update to latest
e45f4fe 
Closes #2280
Closes #2296
Closes #2297
Closes #2298
@barmac barmac mentioned this issue Jun 17, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jun 17, 2021
@barmac
Copy link
Collaborator

barmac commented Jun 17, 2021

Closed via #2315

@barmac barmac closed this as completed Jun 17, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 17, 2021
nikku pushed a commit that referenced this issue Jul 6, 2021
@barmac @merge-me
deps: update to latest
72a435c 
Closes #2280
Closes #2296
Closes #2297
Closes #2298
@philippfromme philippfromme mentioned this issue Jul 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working channel:support
Projects
None yet
Milestone
M48
Development

Successfully merging a pull request may close this issue.

deps: update to latest camunda/camunda-modeler
4 participants
@nikku @philippfromme @pinussilvestrus @barmac