Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms are not XML/HTML encoded #2365

Closed
korthout opened this issue Jul 9, 2021 · 4 comments · Fixed by #2369
Closed

Forms are not XML/HTML encoded #2365

korthout opened this issue Jul 9, 2021 · 4 comments · Fixed by #2369
Labels
BPMN bug Something isn't working Camunda 8 Flags an issue as related to Camunda 8
Milestone
M49

Comments

@korthout
Copy link
Member

korthout commented Jul 9, 2021 •
edited by nikku
Loading

Describe the Bug

Forms that define xml tags in the label, description, etc are not xml/html encoded.

Steps to Reproduce

  1. create a new form
  2. add a text field
  3. write in the description: Hello, <world>!
  4. go to json view
  5. copy json
  6. paste into a Camunda Cloud user task
  7. go to xml view
  8. see that it breaks the xml

Expected Behavior

Values defined in the form editor should be xml/html encoded.

For example, Hello, <world>! should be encoded to Hello, &lt;world&gt;! (I think)

Environment

  • OS: macOS 11.4 / any
  • Camunda Modeler Version: 4.8.1 (4.8.1.8069)
  • Execution Platform: Camunda Cloud (but probably also on Camunda Platform)
@korthout korthout added bug Something isn't working platform:Darwin Forms Camunda 8 Flags an issue as related to Camunda 8 labels Jul 9, 2021
@korthout korthout changed the title Forms are not XML encoded Forms are not XML/HTML encoded Jul 9, 2021
@nikku
Copy link
Member

nikku commented Jul 9, 2021

I can reproduce the issue.

@nikku nikku added the ready Ready to be worked on label Jul 9, 2021
@nikku
Copy link
Member

nikku commented Jul 9, 2021

Congratulations by the way. You surfaced a low-level XML serialization bug. We don't have many of these around, anymore 🥇

nikku added a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 9, 2021
@nikku
fix: correct moddle string->String type
764d635 
This prevents encoding errors as elements are properly regarded as
encodeable.

Related to camunda/camunda-modeler#2365
@nikku
Copy link
Member

nikku commented Jul 9, 2021

Actually just a zeebe-bpmn-moddle meta-model bug 😿.

@nikku nikku added needs review Review pending and removed ready Ready to be worked on labels Jul 11, 2021 — with bpmn-io-tasks
philippfromme pushed a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 14, 2021
@nikku @philippfromme
fix: correct moddle string->String type
4553dea 
This prevents encoding errors as elements are properly regarded as
encodeable.

Related to camunda/camunda-modeler#2365
philippfromme pushed a commit to camunda/zeebe-bpmn-moddle that referenced this issue Jul 14, 2021
@nikku @philippfromme
fix: correct moddle string->String type
ddd231f 
This prevents encoding errors as elements are properly regarded as
encodeable.

Related to camunda/camunda-modeler#2365
@nikku nikku added fixed upstream Requires integration of upstream change and removed needs review Review pending labels Jul 14, 2021
nikku added a commit to camunda/camunda-bpmn-js that referenced this issue Jul 14, 2021
@nikku
deps: bump to zeebe-bpmn-moddle@0.7.1
b3665f7 
Corrects encoding of user task form definitions.

Related to camunda/camunda-modeler#2365
nikku added a commit that referenced this issue Jul 14, 2021
@nikku
deps: bump zeebe-bpmn-moddle
fa270dc 
Closes #2365
@nikku nikku mentioned this issue Jul 14, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jul 14, 2021
@pinussilvestrus
Copy link
Contributor

Closed via #2369

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 15, 2021
@pinussilvestrus pinussilvestrus added this to the M49 milestone Jul 15, 2021
MaxTru pushed a commit that referenced this issue Sep 8, 2021
@nikku @merge-me
deps: bump zeebe-bpmn-moddle
e02abe0 
Closes #2365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BPMN bug Something isn't working Camunda 8 Flags an issue as related to Camunda 8
Projects
None yet
Milestone
M49
Development

Successfully merging a pull request may close this issue.

deps: bump zeebe-bpmn-moddle camunda/camunda-modeler
3 participants
@nikku @korthout @pinussilvestrus