Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of "Remember credentials" toggle in deployment #2860

Closed
2 tasks
smbea opened this issue Mar 28, 2022 · 3 comments · Fixed by #2881
Closed
2 tasks

Improve UX of "Remember credentials" toggle in deployment #2860

smbea opened this issue Mar 28, 2022 · 3 comments · Fixed by #2881
Assignees

Comments

@smbea
Copy link
Contributor

smbea commented Mar 28, 2022

What should we do?

Improve the UX of "Remember credentials" toggle in the deployment overlay for Cloud.

  • Make 'Remember credentials' toggle always available (currently not available for self-managed target with no OATH)
  • Save credentials onClose, regardless if the deployment succeed

Why should we do it?

This is part of a bigger effort to improve the UX of the deployment journey (see #2707)


Child of #2707

@smbea smbea changed the title Save credentials onSubmit and onClose Save credentials onSubmit and onClose Mar 28, 2022
@smbea smbea changed the title Save credentials onSubmit and onClose Improve UX of "Remember credentials" toggle in deployment Mar 28, 2022
@smbea smbea added the ready Ready to be worked on label Mar 28, 2022
@smbea smbea self-assigned this Mar 28, 2022
@smbea
Copy link
Contributor Author

smbea commented Apr 1, 2022

I decided to save credentials only on close since they are only reset (to the saved ones)when opening the overlay again

@andreasgeier
Copy link

I decided to save credentials only on close since they are only reset (to the saved ones)when opening the overlay again

If one adds/changes the credentials (toggle was already activated or has been activated) and then deploys, are the new credentials stored?

@smbea
Copy link
Contributor Author

smbea commented Apr 1, 2022

  • If deploy successful -> it will always save
  • If deploy connection cannot be established (wrong credentials or so) -> validation kicks-in so the deploy doesn't proceed and the overlay doesn't close. But if you close it later it saves.

I hope this makes sense, but I will add you as a reviewer for this PR and you can test the artifact.

smbea added a commit that referenced this issue Apr 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Apr 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Apr 1, 2022
@smbea smbea added the in progress Currently worked on label Apr 4, 2022 — with bpmn-io-tasks
@smbea smbea removed the needs review Review pending label Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 4, 2022
smbea added a commit that referenced this issue Apr 5, 2022
@smbea smbea added the needs review Review pending label Apr 5, 2022 — with bpmn-io-tasks
@smbea smbea removed the in progress Currently worked on label Apr 5, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 5, 2022
smbea added a commit that referenced this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants